Skip to content

Add CitationEntity & citation extension methods#361

Merged
corinagum merged 5 commits intonext/corefrom
cg/next-citations
Mar 5, 2026
Merged

Add CitationEntity & citation extension methods#361
corinagum merged 5 commits intonext/corefrom
cg/next-citations

Conversation

@corinagum
Copy link
Contributor

@corinagum corinagum commented Mar 3, 2026

Port CitationEntity and supporting types from main, adapted for next/core.

  • Adds AddCitation, AddAIGenerated, and AddFeedback methods to TeamsActivity
  • Enables OMessage sub-dispatch in EntityList.FromJsonArray() with @type routing ("Message" --> CitationEntity, "CreativeWork" --> SensitiveUsageEntity)
  • Adds typed FeedbackLoopEnabled property to TeamsChannelData
  • Registers new citation types in TeamsActivityJsonContext: (CitationEntity, CitationClaim, CitationAppearanceDocument, CitationImageObject, CitationAppearance)
  • Registers previously missing entity types in TeamsActivityJsonContext: (OMessageEntity, SensitiveUsageEntity, DefinedTerm, ProductInfoEntity, StreamInfoEntity)
  • Unit tests

Notes

  • Not porting UpdateEntity(IEntity, IEntity); AddCitation does remove + add inline
  • Samples.AI/CitationsHandler not ported
  • IMessageEntity not needed - concrete classes only in 2.1
  • IMessageJsonConverter replaced by DeserializeMessageEntity in EntityList

@corinagum corinagum force-pushed the cg/next-citations branch from 4928e12 to ec5f268 Compare March 3, 2026 21:57
@rido-min rido-min added the CORE label Mar 4, 2026
Copy link
Member

@rido-min rido-min left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are looking good !!

I would add some sample code, maybe in TeamsBot to show citations in action.

and a few notes in the comments

@rido-min
Copy link
Member

rido-min commented Mar 4, 2026

  • No samples use core namespaces yet

We have samples for Core, Compat and new FrontEnd in core/samples

@corinagum corinagum merged commit 520c2e0 into next/core Mar 5, 2026
3 checks passed
@corinagum corinagum deleted the cg/next-citations branch March 5, 2026 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants