Hosting changes: refactoring & support no-auth setup scenario#384
Hosting changes: refactoring & support no-auth setup scenario#384
Conversation
|
from the screenshots, seems we are duplicating the same Warning multiple times. Can we review those logs to have a single entry? |
rido-min
left a comment
There was a problem hiding this comment.
LGTM, but I'd like to validate in a real environment with UMI and FIC before merging
core/src/Microsoft.Teams.Bot.Core/Hosting/AddBotApplicationExtensions.cs
Show resolved
Hide resolved
| TenantId = section["TenantId"] ?? string.Empty, | ||
| ClientId = section["ClientId"] ?? string.Empty, | ||
| ClientSecret = section["ClientSecret"], | ||
| Scope = section["Scope"] ?? configuration["Scope"] ?? BotScope, |
There was a problem hiding this comment.
we need to clarify where to read the Scope from, seems we are reading from the root, and from the section
There was a problem hiding this comment.
Good catch, in Msal config format scope should be read from the section only.
core/src/Microsoft.Teams.Bot.Core/Hosting/MsalConfigurationExtensions.cs
Show resolved
Hide resolved
yeah, i will do another pass of refactoring to avoid redundant log statements |
rido-min
left a comment
There was a problem hiding this comment.
LGTM, the only missing piece is to clarify where to read the scope from, and I'm fine doing it in a next PR

RequireAuthorizationin CompatBot sample.BotConfigas single source for reading & propagating configuration instead of doing that all over.Logs when setting up auth using the different config formats
No credentials setup
Testing with Agents Plaground
edit: it had multiple redundant logs before
Msal Config setup
Core config setup
BF config setup