chore: Add default params to cancellation token for backwards compatibility#412
Merged
chore: Add default params to cancellation token for backwards compatibility#412
Conversation
corinagum
approved these changes
Apr 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the default sign-in invoke handlers in Microsoft.Teams.Apps to make their CancellationToken parameter optional, aiming to reduce breaking changes for callers that previously didn’t pass a token.
Changes:
- Added
= defaultto theCancellationTokenparameter for three protected sign-in activity handlers. - Keeps existing routing registrations that pass
context.CancellationTokenintact while allowing direct calls to omit the token.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this is a protected method it could've been overriden, adding the default param ensures that the cancellation token need not be provided. This prevents breaking when bumping from < 2.0.6 versions where the param was not there in the first place.