Conversation
Add tests to verify that when APX returns 202 Accepted with no body: - SendToConversationWithHttpMessagesAsync returns string.Empty for Id - ReplyToActivityWithHttpMessagesAsync returns string.Empty for Id This ensures the fix maintains API contract by never returning null for ResourceResponse.Id Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Update ConversationClientTests to handle nullable SendActivityResponse - Update Proactive Worker sample to handle nullable response Fixes CI build errors after making SendActivityAsync return nullable. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Update ConversationClientTest to handle nullable SendActivityResponse (8 occurrences) - Update TeamsApiFacadeTests to handle nullable SendActivityResponse (5 occurrences) This completes the nullability fixes for all test files. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
singhk97
commented
Apr 9, 2026
| ResourceResponse resourceResponse = new() | ||
| { | ||
| Id = response.Id | ||
| Id = response?.Id ?? string.Empty |
Collaborator
Author
There was a problem hiding this comment.
string.Empty to not break api contract. ResourceResponse.Id is a string.
rido-min
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Null-safe Handling of Send Activity Responses:
SendAsyncinActivitiesApi.cstoTask<SendActivityResponse?>, allowing for null responses when the service returns no body.TeamsStreamingWriter.csto handle potentially nullSendActivityResponseobjects in bothSendInformativeUpdateAsyncandAppendResponseAsync, ensuring_streamIdis only set if a response is present. [1] [2]CompatConversations.csto handle nullSendActivityResponseobjects when replying to activities, defaulting the resource response ID to an empty string if necessary.