Remove supportsThreading guard from Reply()#434
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the SDK-side allowlist/guard for “threading-capable” conversation IDs so that Reply(conversationId, messageId, ...) always constructs a threaded conversation ID and lets the service determine whether threading is supported.
Changes:
- Removed the
supportsThreadingfallback inApp.Reply()(3-arg/threaded form) and always callsConversation.ToThreadedConversationId(...). - Updated the threading sample (
Program.cs+ README) to remove the conversation-type guard and reflect the new behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Samples/Samples.Threading/README.md | Updates sample docs to remove the conversation-type guard assumptions and describe service-driven threading behavior. |
| Samples/Samples.Threading/Program.cs | Removes local suffix allowlist check and always constructs a threaded conversation ID for the manual command. |
| Libraries/Microsoft.Teams.Apps/App.cs | Changes Reply(conversationId, messageId, ...) to always build a threaded conversation ID (no fallback). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MehakBindra
approved these changes
Apr 22, 2026
singhk97
approved these changes
Apr 22, 2026
corinagum
force-pushed
the
cg/remove-threading-guard
branch
from
aa502e7 to
12e8610
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
supportsThreadingguard fromReply()3-arg form -- always callsConversation.ToThreadedConversationId()when messageId is providedtest manualexample to remove conversation type guardWhy: Threading support is expanding (channels, 1:1, group chats). Maintaining an allowlist of conversation ID suffixes creates a maintenance burden and can block developers from using newly supported scopes until the SDK is updated.
Test plan
🤖 Generated with Claude Code