Conversation
…and improve citation handling
rajan-chari
approved these changes
Apr 22, 2026
Contributor
rajan-chari
left a comment
There was a problem hiding this comment.
Got it merge from main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to cloud environment support and authentication flexibility in the Teams API SDK, while also cleaning up legacy and experimental features. The main focus is on enabling multi-cloud support (including USGov, DoD, and China) through a new
CloudEnvironmentabstraction, updating authentication flows to use cloud-specific endpoints, and ensuring that token and service URLs are configurable and propagated across client instances. Additionally, the pipeline configuration is modernized and consolidated.Cloud Environment & Authentication Enhancements
CloudEnvironmentclass inMicrosoft.Teams.Api.Auth, encapsulating all cloud-specific endpoints, scopes, and service URLs, with predefined instances for Public, USGov, USGovDoD, and China clouds, and support for custom environments. (Libraries/Microsoft.Teams.Api/Auth/CloudEnvironment.cs)ClientCredentialsto accept and use aCloudEnvironmentproperty, ensuring that all authentication requests (token endpoints, tenants, etc.) are cloud-aware and configurable. (Libraries/Microsoft.Teams.Api/Auth/ClientCredentials.cs) [1] [2]Client Propagation of Cloud Settings
ApiClientand related sub-clients to propagate cloud-specific token service URLs and scopes, ensuring consistent behavior when cloning or instantiating new clients with different cancellation tokens. (Libraries/Microsoft.Teams.Api/Clients/ApiClient.cs)BotSignInClientto use a configurableTokenServiceUrlproperty instead of a hardcoded URL, and applied this property in all relevant API calls. (Libraries/Microsoft.Teams.Api/Clients/BotSignInClient.cs) [1] [2] [3]Pipeline Modernization
.azdo/publish.yaml,.azdo/publish.yml) [1] [2]Legacy/Experimental Cleanup
IsTargetedproperty and related logic from theActivityclass, simplifying the activity model and removing obsolete code paths. (Libraries/Microsoft.Teams.Api/Activities/Activity.cs) [1] [2] [3]