Skip to content

Merge main into next/core #438

Merged
rido-min merged 2 commits intonext/corefrom
next/core-merge-main421
Apr 22, 2026
Merged

Merge main into next/core #438
rido-min merged 2 commits intonext/corefrom
next/core-merge-main421

Conversation

@rido-min
Copy link
Copy Markdown
Member

This pull request introduces significant improvements to cloud environment support and authentication flexibility in the Teams API SDK, while also cleaning up legacy and experimental features. The main focus is on enabling multi-cloud support (including USGov, DoD, and China) through a new CloudEnvironment abstraction, updating authentication flows to use cloud-specific endpoints, and ensuring that token and service URLs are configurable and propagated across client instances. Additionally, the pipeline configuration is modernized and consolidated.

Cloud Environment & Authentication Enhancements

  • Introduced the CloudEnvironment class in Microsoft.Teams.Api.Auth, encapsulating all cloud-specific endpoints, scopes, and service URLs, with predefined instances for Public, USGov, USGovDoD, and China clouds, and support for custom environments. (Libraries/Microsoft.Teams.Api/Auth/CloudEnvironment.cs)
  • Updated ClientCredentials to accept and use a CloudEnvironment property, ensuring that all authentication requests (token endpoints, tenants, etc.) are cloud-aware and configurable. (Libraries/Microsoft.Teams.Api/Auth/ClientCredentials.cs) [1] [2]

Client Propagation of Cloud Settings

  • Modified ApiClient and related sub-clients to propagate cloud-specific token service URLs and scopes, ensuring consistent behavior when cloning or instantiating new clients with different cancellation tokens. (Libraries/Microsoft.Teams.Api/Clients/ApiClient.cs)
  • Updated BotSignInClient to use a configurable TokenServiceUrl property instead of a hardcoded URL, and applied this property in all relevant API calls. (Libraries/Microsoft.Teams.Api/Clients/BotSignInClient.cs) [1] [2] [3]

Pipeline Modernization

  • Migrated and consolidated the NuGet publishing pipeline to use the 1ES Official Pipeline Template, supporting both internal and public publishing, with improved security compliance and parameterization. (.azdo/publish.yaml, .azdo/publish.yml) [1] [2]

Legacy/Experimental Cleanup

  • Removed the experimental IsTargeted property and related logic from the Activity class, simplifying the activity model and removing obsolete code paths. (Libraries/Microsoft.Teams.Api/Activities/Activity.cs) [1] [2] [3]

@rido-min rido-min added the CORE label Apr 21, 2026
@rido-min rido-min changed the title merge from main Merge main into next/core Apr 21, 2026
Copy link
Copy Markdown
Contributor

@rajan-chari rajan-chari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it merge from main.

@rido-min rido-min merged commit f38fe15 into next/core Apr 22, 2026
7 checks passed
@rido-min rido-min deleted the next/core-merge-main421 branch April 22, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants