Set versionHeightOffset to -2 in core version.json files#500
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts Nerdbank.GitVersioning height offsets for Core package versioning, including the Core root version file and the per-project override for Microsoft.Teams.Apps.
Changes:
- Updates
core/version.jsonversionHeightOffsetfrom-1to-2. - Adds
versionHeightOffset: -2to theMicrosoft.Teams.Appsproject-specific version file.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
core/version.json |
Adjusts the Core package set version height offset. |
core/src/Microsoft.Teams.Apps/version.json |
Adds the same offset to the Apps per-project version override. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rido-min
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
versionHeightOffsetto-2incore/version.json(was-1).versionHeightOffset: -2tocore/src/Microsoft.Teams.Apps/version.json(field was absent).Test plan
mainbuilds.