Skip to content

Set versionHeightOffset to -2 in core version.json files#500

Merged
singhk97 merged 1 commit into
mainfrom
kavin/version-height-offset
May 13, 2026
Merged

Set versionHeightOffset to -2 in core version.json files#500
singhk97 merged 1 commit into
mainfrom
kavin/version-height-offset

Conversation

@singhk97
Copy link
Copy Markdown
Collaborator

@singhk97 singhk97 commented May 13, 2026

Summary

  • Set versionHeightOffset to -2 in core/version.json (was -1).
  • Add versionHeightOffset: -2 to core/src/Microsoft.Teams.Apps/version.json (field was absent).

Test plan

  • Verify Nerdbank.GitVersioning resolves the expected version height on main builds.
  • Verify Core package versions produced by CI reflect the new offset.

Copilot AI review requested due to automatic review settings May 13, 2026 16:56
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts Nerdbank.GitVersioning height offsets for Core package versioning, including the Core root version file and the per-project override for Microsoft.Teams.Apps.

Changes:

  • Updates core/version.json versionHeightOffset from -1 to -2.
  • Adds versionHeightOffset: -2 to the Microsoft.Teams.Apps project-specific version file.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
core/version.json Adjusts the Core package set version height offset.
core/src/Microsoft.Teams.Apps/version.json Adds the same offset to the Apps per-project version override.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@singhk97 singhk97 merged commit 8b193de into main May 13, 2026
14 checks passed
@singhk97 singhk97 deleted the kavin/version-height-offset branch May 13, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants