Fix construction of DynamicBaseModel if the parameter schema is a dict #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where function parameters specified as dictionaries (rather than Pydantic models) couldn't be properly handled when creating dynamic models for parsing. The fix allows dynamic models to accept arbitrary fields using Pydantic's extra="allow" configuration.
Key changes:
- Added
ConfigDict(extra="allow")to dynamic model creation to handle empty or arbitrary parameter dictionaries - Updated type hints from
Function[BaseModel]toFunction[Any]to better reflect the actual usage - Added comprehensive unit tests covering various parameter schema scenarios including the specific bug case
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/openai/src/microsoft/teams/openai/function_utils.py | Fixed dynamic model creation to allow extra fields and updated type hints |
| packages/openai/tests/test_function_utils.py | Added comprehensive test suite covering all parameter schema scenarios and edge cases |
heyitsaamir
changed the title
lilyydu
approved these changes
Oct 17, 2025
MehakBindra
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had a bug where if you specified the function parameters as a Dict (and not a pydantic model), then the Dynamic model wouldn't correctly build the parameters. The fix was pretty simple - allowing "extra". Also added some unit tests.