fix: downgrade expected token exchange failure logs from error to info#305
Merged
heyitsaamir merged 3 commits intomainfrom Mar 6, 2026
Merged
fix: downgrade expected token exchange failure logs from error to info#305heyitsaamir merged 3 commits intomainfrom
heyitsaamir merged 3 commits intomainfrom
Conversation
The SSO token exchange returns 400/404/412 as part of the normal sign-in flow to trigger the permission picker UI. These expected failures were logged at ERROR level, creating noise. Now only unexpected HTTP errors log at ERROR; expected failures log at INFO. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
lilyydu
approved these changes
Mar 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts OAuth SSO token-exchange logging in the Teams apps SDK to reduce noise for expected “permission picker” flows while preserving error reporting for unexpected failures.
Changes:
- Downgrades logging for expected SSO token exchange failures (HTTP 400/404/412) from WARNING to INFO.
- Keeps ERROR logging + error event emission for unexpected HTTP status errors during token exchange.
You can also share your feedback on Copilot code review. Take the survey.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Address PR review comments: - Use `log` variable instead of `ctx.logger` for consistency - Keep error-level logging + error event for non-HTTPStatusError exceptions - Only downgrade to info for expected HTTP 400/404/412 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ERROR+WARNINGtoINFOERRORlevel and emit error eventsTest plan
INFOlevel instead ofERRORERRORlevel🤖 Generated with Claude Code