Conversation
corinagum
force-pushed
the
cg/remove-reply-to-id
branch
from
4a51e3c to
59347d9
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Removes the with_reply_to_id() fluent builder method from Activity, since reply_to_id on outgoing activities is ignored by the service and the method is misleading.
Changes:
- Remove
Activity.with_reply_to_id()from the model fluent API. - Update unit tests to stop setting/asserting
reply_to_idvia the removed helper.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/api/src/microsoft_teams/api/models/activity.py | Removes the with_reply_to_id() builder method from Activity. |
| packages/api/tests/unit/test_activity.py | Updates the activity builder unit test to no longer use/assert reply_to_id. |
lilyydu
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with_reply_to_id()methodreply_to_idis a field on the activity that is used by the service, but any changes to it on the bot side are completely ignored. After thorough testing to confirm, this PR removes the misleading methodwith_reply_to_id; setting replyToId on outgoing activities is a no-op.Originally part of #321 but separated out due to timing concerns for GA