Remove supports_threading guard from app.reply()#396
Merged
Conversation
This reverts commit c783a7c.
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the SDK-side allowlist/guard for threaded replies so App.reply() consistently constructs a threaded conversation id when a message_id is provided, delegating “does this scope support threading?” to the Teams service.
Changes:
- Remove
supports_threading()andTHREADING_SUFFIXES, and delete the related unit tests. - Update
App.reply()3-arg form to always callto_threaded_conversation_id()whenmessage_idis provided. - Simplify the threading example by removing the local conversation-type guard and update its README accordingly.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/apps/tests/test_thread.py | Removes supports_threading tests; keeps to_threaded_conversation_id coverage. |
| packages/apps/src/microsoft_teams/apps/utils/thread.py | Deletes supports_threading + suffix allowlist; retains only to_threaded_conversation_id. |
| packages/apps/src/microsoft_teams/apps/app.py | Updates App.reply() to always thread in 3-arg form and adjusts docstring/imports. |
| examples/threading/src/main.py | Removes manual “conversation type supports threading” guard in the sample. |
| examples/threading/README.md | Updates sample documentation to match new behavior/expectations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
supports_threading()guard fromapp.reply()3-arg form -- always callsto_threaded_conversation_id()when message_id is providedsupports_threading()function andTHREADING_SUFFIXESconstant (dead code)supports_threadingteststest manualexample to remove conversation type guardWhy: Threading support is expanding (channels, 1:1, group chats). Maintaining an allowlist of conversation ID suffixes creates a maintenance burden and can block developers from using newly supported scopes until the SDK is updated.
Test plan
🤖 Generated with Claude Code