fix agent-framework pyright issue and added examples to CI#400
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Pyright type-check failures in the examples/ai-agentframework workspace member by switching from the agent-framework wrapper package to agent-framework-core[all], and updates CI path filters so changes under examples/ trigger the main workflow.
Changes:
- Update
examples/ai-agentframeworkto depend onagent-framework-core[all]instead ofagent-framework. - Regenerate
uv.lockto removeagent-frameworkand lock the new dependency graph for the example. - Expand
.github/workflows/ci.ymlpath filters to includeexamples/**on PRs and pushes tomain.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
uv.lock |
Removes agent-framework and locks agent-framework-core[all] for the ai-agentframework example. |
examples/ai-agentframework/pyproject.toml |
Switches the example dependency to agent-framework-core[all] to resolve Pyright import/type visibility. |
.github/workflows/ci.yml |
Ensures CI runs when examples/** changes (not only packages/**). |
MehakBindra
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Pyright was failing on the
ai-agentframeworkexample.The agent-framework package pulls in a bunch of optional sub-packages via its [all] extra. One of those —
agent-framework-azure-ai-search==0.0.0a1— is a broken placeholder alpha that accidentally ships an empty agent_framework/init.py in its wheel. When installed, that empty file overwrites the real one from agent-framework-core, so Python sees an empty agent_framework namespace and pyright can't find Agent, AgentSession, tool, etc.Replaced imports with
agent-framework-coreandagent-framework-openaipackages, resycned lock file2. CI wasn't running on examples
Our workflows were only set up to run when files under
packages/changed. This bug was undetected when the sample was added, so proposing to run our examples in CI too.