Skip to content

Pane::_FindFocusAndNeighbor can probably be simpler #10748

@zadjii-msft

Description

@zadjii-msft

If we view this problem from the point of the focused pane, what this function (and the other) do is basically:

  • move to the parent node
  • check if the other child node - the one the focused pane doesn't belong to - is in the direction we want to move the pane to
    • if yes: swap panes
    • if no: continue with the parent node

Is that correct?
If my understanding is correct, I believe we can simplify this code after it has been merged.

Originally posted by @lhecker in #10638 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Help WantedWe encourage anyone to jump in on these.Issue-TaskIt's a feature request, but it doesn't really need a major design.Product-TerminalThe new Windows Terminal.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions