-
Notifications
You must be signed in to change notification settings - Fork 9.2k
Actions without keys should be rejected #10944
Copy link
Copy link
Open
Labels
Area-SettingsIssues related to settings and customizability, for console or terminalIssues related to settings and customizability, for console or terminalIssue-BugIt either shouldn't be doing this or needs an investigation.It either shouldn't be doing this or needs an investigation.Product-TerminalThe new Windows Terminal.The new Windows Terminal.
Milestone
Metadata
Metadata
Assignees
Labels
Area-SettingsIssues related to settings and customizability, for console or terminalIssues related to settings and customizability, for console or terminalIssue-BugIt either shouldn't be doing this or needs an investigation.It either shouldn't be doing this or needs an investigation.Product-TerminalThe new Windows Terminal.The new Windows Terminal.
Extracted from #10933.
Steps to reproduce
Add this to your "actions":
{ "command": "unbound", "keys": "" }Expected behavior
The application should ignore/reject such actions and optionally remove or warn about them.
Actual behavior
ActionMapis being filled with such actions without validation.Additionally the bug reporter (@Rosefield) mentioned that they can't remember adding such an action by themselves. It might thus be necessary to add further
assert()s to find further causes elsewhere.