All nested commands get keybindings (`ctrl+t`) in command palette?

[zadjii-msft]

main, ~ e006f75

Something is WRONG with all nested commands:

You'll note, they seemingly all have ctrl+t as their keychord text.

This doesn't repro for me on 1.22.2334.0

Looking now at my settings to see if there's something sus in there...

[zadjii-msft]

Yes this is sus...

I actually have quite a few of these:

        {
            "id": null,
            "keys": "ctrl+t"
        },
        {
            "id": "User.showContextMenu",
            "keys": "ctrl+z"
        },
        {
            "id": "User.scrollToMark.6CD791B",
            "keys": "ctrl+pgdn"
        },
        {
            "id": "User.movePane.6E7070F6",
            "keys": "f3"
        },
        {
            "id": "User.movePane.B137036",
            "keys": "f4"
        },
        {
            "id": "User.closeTab.0",
            "keys": "ctrl+w"
        },
        {
            "id": "User.showSuggestions.807E15EE",
            "keys": "ctrl+shift+h"
        },
        {
            "id": null,
            "keys": "ctrl+shift+comma"
        },
        {
            "id": null,
            "keys": "ctrl+shift+period"
        },
        {
            "id": null,
            "keys": "ctrl+shift+/"
        },
        {
            "id": null,
            "keys": "ctrl+shift+;"
        },

I have no memory of what these were. Alas, sublime doesn't have the undo stack to a state before they were added. If I had to guess, commands that are no longer valid? Like, I bet ctrl+t was tasks (which over the course of time was turned into showSuggestions)

[zadjii-msft]

Deleting those fixes it. And adding back a

        {
            "id": null,
            "keys": "ctrl+x"
        },

adds back a ctrl+x label to the cmdpal. I guess we're just handling the logic in here a little wack.

• We probably shouldn't be assigning a keychord for the "null" command ID to every nested command?
• Nested commands should have their command labels not on top of the > arrow (s.t. when Allow binding keys to a nested action, to open the palette directly to it's children #10209 is added, this will look right)