-
Notifications
You must be signed in to change notification settings - Fork 9k
Closed
Labels
Issue-BugIt either shouldn't be doing this or needs an investigation.It either shouldn't be doing this or needs an investigation.Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meetingIt's a new issue that the core contributor team needs to triage at the next triage meeting
Description
Windows Terminal version
No response
Windows build number
10.0.19045.6456
Other Software
No response
Steps to reproduce
Replace system conhost.exe, run profiling in Visual Studio.
Expected Behavior
No response
Actual Behavior
conhost crashes due to uncaught exception. Creating ITfCategoryMgr here fails
terminal/src/tsf/Implementation.cpp
Line 73 in 224ac9d
| _categoryMgr = wil::CoCreateInstance<ITfCategoryMgr>(CLSID_TF_CategoryMgr, CLSCTX_INPROC_SERVER); |
and throws the exception.
Gracefully handling that here
Line 15 in 224ac9d
| handle._impl->Initialize(); |
as assigning
nullptr to handle._impl solves the problem.
I can create a pull request if you want.
Metadata
Metadata
Assignees
Labels
Issue-BugIt either shouldn't be doing this or needs an investigation.It either shouldn't be doing this or needs an investigation.Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meetingIt's a new issue that the core contributor team needs to triage at the next triage meeting