Pressing Enter while using an IME closes the tab title edit box

[InTka]

Windows Terminal version

1.24.10921.0

Windows build number

10.0.26200.0

Other Software

No response

Steps to reproduce

1. Activate Microsoft Pinyin IME.
2. Click on a tab title to start editing it.
3. Type some Pinyin letters (for example, “nihao”) so that the IME candidate window appears.
4. While the candidate window is still open, press Enter.

Expected Behavior

Pressing Enter should only commit the raw typed letters. The edit box should remain open so that the user can continue editing.

Actual Behavior

The raw typed letters are committed, and the tab title edit box closes immediately.

[DHowett]

I bet we have a stray key event handler on the input box because it was needed at some point in the past.

terminal/src/cascadia/TerminalApp/TabHeaderControl.cpp

Lines 39 to 46 in fb71a04

	HeaderRenamerTextBox().KeyUp([&](auto&&, const Windows::UI::Xaml::Input::KeyRoutedEventArgs& e) {
	if (_receivedKeyDown)
	{
	if (e.OriginalKey() == Windows::System::VirtualKey::Enter)
	{
	// User is done making changes, close the rename box
	_CloseRenameBox();
	}

That's not great. We should figure out why we did that, and then fix it while making sure to ensure that the original bug doesn't come back.

I shouldn't need to say this, but I know some LLM-powered robot is just going to come through and remove these 5 lines of code and proudly proclaim success otherwise.