-
Notifications
You must be signed in to change notification settings - Fork 9.2k
[Audit] Remove suppression of hidden methods on TextBufferTextIterator #2682
Copy link
Copy link
Open
Labels
Area-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Area-OutputRelated to output processing (inserting text into buffer, retrieving buffer text, etc.)Related to output processing (inserting text into buffer, retrieving buffer text, etc.)Issue-TaskIt's a feature request, but it doesn't really need a major design.It's a feature request, but it doesn't really need a major design.Product-ConhostFor issues in the Console codebaseFor issues in the Console codebaseProduct-TerminalThe new Windows Terminal.The new Windows Terminal.
Milestone
Description
Metadata
Metadata
Assignees
Labels
Area-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Area-OutputRelated to output processing (inserting text into buffer, retrieving buffer text, etc.)Related to output processing (inserting text into buffer, retrieving buffer text, etc.)Issue-TaskIt's a feature request, but it doesn't really need a major design.It's a feature request, but it doesn't really need a major design.Product-ConhostFor issues in the Console codebaseFor issues in the Console codebaseProduct-TerminalThe new Windows Terminal.The new Windows Terminal.
This is very related to #2681 and will probably be fixed at the same time or with a better design that could encompass both of these.
The issue is that the Text iterator inherits from the Cell one. Which is probably not right. It should probably encapsulate it or something.
The original idea when I was scrabbling those iterators together was to not waste time advancing the portions of the iterator that weren't related to the text if all the end consumer wanted was the text. But it doesn't even look like I achieved that and I introduced things that are turning into gross situations and warnings.