A color is always brighter as Foreground than Background

[krokofant]

Environment
Windows build number: 10.0.18362.86
At Commit: 6c98fc1

What you're doing and what's happening:
Open a PowerShell prompt via the Terminal and execute a command that paints the foreground same as the background:

Write-Host "FOO BAR" -ForegroundColor DarkBlue -BackgroundColor DarkBlue

What's wrong / what should be happening instead:
The foreground is always a little bit brighter

Edit:
With the standard PowerShell theme it's easier to spot when using red:

Write-Host "FOO BAR" -ForegroundColor DarkRed -BackgroundColor DarkRed

[zadjii-msft]

I'm not seeing lighter, but I am seeing different. That's crazy.

[krokofant]

It actually seems like it's the background that is darker in the Terminalen compared to pwsh only.

[ghosty141]

I found the issue/line that causes this, I'm not sure though, why this exists and if removing is fine. The issue is in DxRenderer.cpp where the following line changes the background color:

_d2dBrushBackground->SetOpacity(.9f);

Removing it fixes the issue.

[krokofant]

@ghosty141 Great!

[PhMajerus]

Good catch !
I was wondering why I was seeing modified colors in ANSI-art that used both background and foreground in my screenshots on #455.