Skip to content

Duplicate line in TermControl #732

@dannyd89

Description

@dannyd89

I've found a duplicate line in the TermControl::Create function, either its missing to initialize the vertical alignment or it's just double setting the horizontal one.

https://github.com/microsoft/Terminal/blob/1e478ae99d53a5f54483becfb6c3b379077b8fd9/src/cascadia/TerminalControl/TermControl.cpp#L80

I would have filed a PR but I don't have the environment to do this currently, I hope it's helpful anyway.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Area-TerminalControlIssues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.)Help WantedWe encourage anyone to jump in on these.Issue-BugIt either shouldn't be doing this or needs an investigation.Product-TerminalThe new Windows Terminal.Resolution-Fix-AvailableIt's available in an Insiders build or a release

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions