Skip to content

ReadPendingInput plays unsafe byte/char games with pending data #807

@miniksa

Description

@miniksa

Ported from MSFT: 18047766.

I fixed an immediate crash bug in MSFT: 17987369 that affected this area, but realized at the time that it's really bad that the ReadPendingInput function in the console host is playing games with a void pointer and mix-and-match of byte versus character counting.

This represents investigating what we can do to stop mix/matching the char and byte counts in ReadPendingInput.

@adiviness might be working on something like this with his changes to input to support emoji...

Metadata

Metadata

Assignees

Labels

Area-InputRelated to input processing (key presses, mouse, etc.)Area-ServerDown in the muck of API call servicing, interprocess communication, eventing, etc.Issue-FeatureComplex enough to require an in depth planning process and actual budgeted, scheduled work.Product-ConhostFor issues in the Console codebase

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions