The unfocused background flashes briefly when switching between tabs

[zadjii-msft]

Windows Terminal version (or Windows build number)

1.8+

Other Software

No response

Steps to reproduce

slap

            "unfocusedAppearance": {
                "background": "#888888"
            }

in a profile

Expected Behavior

Maybe there's a way we can not switch to the unfocused appearance when the control is removed from the UI tree entirely? IIRC we were talking about doing a similar thing to prevent the DxRender from doing anything when the tab is inactive

Actual Behavior

Switching between tabs with the same profile briefly flashes the gray color as it fades to the active color. It doesn't look great :confu

[zadjii-msft]

Looks like we'll also pop the unfocused appearance whenever any sort of modal UI is opened within the terminal app. Case in point, the command palette, the new tab flyout, the window renamer

I dunno if we want to include this or make it its own bug. Figured it's kinda related, or could be part of the solution. In all these cases, the control is unfocused, yes, but the pane is still active. Maybe we should only transition to the unfocused appearance if the pane is in the active tab, and is inactive?

[DHowett]

Hmm.. I think making it follow pane activeness will change two fundamental things about it:

1. right now it only needs TerminalControl to know when to switch states (nothing in tab or pane)
2. It will not display the unfocused appearance when the app loses focus, because the active pane doesn’t change

the first is ideological, the second likely goes against why people wanted it in the first place. Hmm.

[zadjii-msft]

Okay then, to massage the idea: maybe we should only transition to the unfocused appearance if ((the pane is in the active tab AND the pane and is inactive) OR (the entire app is inactive))