Skip to content

Conversation

@depletionmode
Copy link

@depletionmode depletionmode commented May 24, 2021

Summary of the Pull Request

Added trace to conhost to instrument buffers that are cooked prior to being passed to the console.

References

  • I've discussed this with core contributors already (internal)

Validation Steps Performed

  • Ensured trace is correctly logged in ETL (via TraceLog)

@depletionmode depletionmode force-pushed the dev/depletionmode/trace-cooked-read branch from a35aae2 to 7293dce Compare May 24, 2021 18:19
@depletionmode depletionmode force-pushed the dev/depletionmode/trace-cooked-read branch from 9f0c683 to a92bace Compare May 24, 2021 18:21
Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@miniksa miniksa added Area-Input Related to input processing (key presses, mouse, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Product-Conhost For issues in the Console codebase labels May 24, 2021
@depletionmode depletionmode marked this pull request as ready for review May 24, 2021 19:35
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label May 24, 2021
@ghost
Copy link

ghost commented May 24, 2021

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 6 hours 23 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@DHowett DHowett merged commit 31e5880 into microsoft:main May 24, 2021
DHowett added a commit that referenced this pull request Jun 10, 2021
Retrieved from https://microsoft.visualstudio.com os.2020 OS official/rs_wdx_dxp_windev 577c9d07360d55609a888d5494de10585024168c

This also reverts 563e20b (inbox).

Related work items: #32957145, #33103239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Input Related to input processing (key presses, mouse, etc.) AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Task It's a feature request, but it doesn't really need a major design. Product-Conhost For issues in the Console codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants