Dev/migrie/b/1042 refactor app to lib #1048
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Load messages from the Resources.resw file
* Display a message when we fail to parse the settings on an initial parse, or
on a reload.
* Unfortunately, the dialog is styled incorrectly when the app theme is
opposite the system theme. This can result in the button being invisible.
…or-dialog # Conflicts: # src/cascadia/CascadiaPackage/Resources/en-US/Resources.resw
# Conflicts: # src/cascadia/TerminalApp/App.cpp
They're no longer ordered, which I hate, but we'll live with.
Involves moving serialization out of AppKeyBindings, because all we have is a cppwinrt type, and Json::Value is not a cppwinrt type
# Conflicts: # src/cascadia/TerminalApp/App.cpp # src/cascadia/TerminalApp/App.h # src/cascadia/TerminalApp/AppKeyBindings.cpp # src/cascadia/TerminalApp/AppKeyBindings.h # src/cascadia/TerminalApp/CascadiaSettingsSerialization.cpp # src/cascadia/TerminalApp/ColorScheme.cpp # src/cascadia/TerminalApp/GlobalAppSettings.cpp # src/cascadia/TerminalApp/Profile.cpp
…pLib project to make a lib. See #1042
|
|
Contributor
|
Please don’t submit pull requests from our branches and code you did not author. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
References
PR Checklist
Detailed Description of the Pull Request / Additional comments