Skip to content

Conversation

@metathinker
Copy link
Contributor

@metathinker metathinker commented May 30, 2019

This small PR renames the text buffer unit test binary file from TextBuffer.UnitTests.dll to TextBuffer.Unit.Tests.dll, with a dot between "Unit" and "Tests". As per the discussion for issue #854, this should be enough to get those tests running in CI.

Detailed Description of the Pull Request / Additional comments

Though it was not strictly necessary, I also renamed the Visual Studio project for TextBuffer.Unit.Tests.dll and its .vcxproj project file.

I also noticed that the 2 tools\ folder commands used to run tests were inconsistent with each other. That is, the PowerShell Invoke-OpenConsoleTests cmdlet was missing some tests run by the {runut,runft,runuia}.cmd batch files (though not the same tests that Azure CI was missing!). So I took the liberty of updating the cmdlet to run those missing tests.

I did not touch the files used in the Windows OS build and test system (the sources file and testmd.definition file). I didn't think this was necessary because the DLLs built by the sources and .vcxproj files are already inconsistent in filename, for this DLL as well as some other binaries built in this repo.

PR Checklist

Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. Thank you very much.

@DHowett-MSFT
Copy link
Contributor

Yay! Thanks!

@DHowett-MSFT DHowett-MSFT merged commit d24d647 into microsoft:master May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check status of TextBuffer Unit Tests in CI

3 participants