Don't create settings.json when it was removed #10877
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
force-pushed
the
dev/lhecker/ignore-settings-remove
branch
from
ebf7512 to
0d946fe
Compare
This comment has been minimized.
This comment has been minimized.
lhecker
added
Area-Settings
Contributor
|
I don't think this is the right answer. What if it was removed purposely for the intention of getting a clean new settings.json? A PR was specifically added and merged to ensure that even while WT is running, a new settings.json could be generated. This PR doesn't support the end user. There must be other ways to address crashes than removing an option that users like myself rely on. |
Member
Author
I imagined that you could just restart the app. |
zadjii-msft
added
Needs-Discussion
Member
|
I think after a few months of idling here, we should just close this PR and revisit in the future if necessary. |
Member
|
We can reopen/revaluate later (: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👉 Open for discussion
Stop recreating settings.json if it's removed.
This improves UX, because users don't accidentally loose their settings anymore
and removes a source of crashes in the SUI. Our WinUI NavigationView crashes
if its MenuItems array is modified while a transition is ongoing.
The crash in particular occurs reliably if the settings are deleted.
PR Checklist
Validation Steps Performed