Fix failing TestHostApp unit tests #11394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Settings
lhecker
force-pushed
the
dev/lhecker/fix-unit-tests
branch
from
2f9b381 to
d64ba9e
Compare
lhecker
commented
Oct 1, 2021
Comment on lines
+1052
to
+1054
| VERIFY_IS_NOT_NULL(actionAndArgs.Args()); | ||
| const auto myArgs = actionAndArgs.Args().as<PrevTabArgs>(); | ||
| VERIFY_ARE_EQUAL(TabSwitcherMode::Disabled, myArgs.SwitcherMode().Value()); |
Member
Author
There was a problem hiding this comment.
Well at least 2 out of 14 failing tests weren't broken by me. That's something. 😄
Comment on lines
+19
to
+42
| static constexpr std::wstring_view inboxSettings{ LR"({ | ||
| "schemes": [{ | ||
| "name": "Campbell", | ||
| "foreground": "#CCCCCC", | ||
| "background": "#0C0C0C", | ||
| "cursorColor": "#FFFFFF", | ||
| "black": "#0C0C0C", | ||
| "red": "#C50F1F", | ||
| "green": "#13A10E", | ||
| "yellow": "#C19C00", | ||
| "blue": "#0037DA", | ||
| "purple": "#881798", | ||
| "cyan": "#3A96DD", | ||
| "white": "#CCCCCC", | ||
| "brightBlack": "#767676", | ||
| "brightRed": "#E74856", | ||
| "brightGreen": "#16C60C", | ||
| "brightYellow": "#F9F1A5", | ||
| "brightBlue": "#3B78FF", | ||
| "brightPurple": "#B4009E", | ||
| "brightCyan": "#61D6D6", | ||
| "brightWhite": "#F2F2F2" | ||
| }] | ||
| })" }; |
Member
Author
There was a problem hiding this comment.
Nowadays CascadiaSettings enforces strict ColorScheme tests as part of its constructor.
zadjii-msft
approved these changes
Oct 4, 2021
|
|
||
| "useAcrylic": false, | ||
| "acrylicOpacity": 0.5, | ||
| "opacity": 50, |
ghost
requested review from
DHowett,
PankajBhojwani,
carlos-zamora,
leonMSFT and
miniksa
carlos-zamora
approved these changes
Oct 5, 2021
DHowett
approved these changes
Oct 5, 2021
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes various failing TestHostApp unit tests.
Most of these broke as part of 168d28b (#11184).
PR Checklist