Fix uninitialized memory access in GetConsoleTitleA test #12699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
the
Area-CodeHealth
lhecker
changed the title
DHowett
approved these changes
Mar 15, 2022
Member
|
Is there a bug linked to this in OS or something? Or, you just found it manually? |
Member
|
@msftbot merge this in 5 minutes |
ghost
added
the
AutoMerge
|
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
Member
Author
The unit tests didn't pass for #12700 so I fixed them. |
ghost
requested review from
PankajBhojwani,
carlos-zamora,
miniksa and
zadjii-msft
zadjii-msft
approved these changes
Mar 17, 2022
DHowett
pushed a commit
that referenced
this pull request
Mar 24, 2022
`WideCharToMultiByte` doesn't write a final null-byte by default. `til::u16u8` avoids the problem. ## PR Checklist * [x] I work here * [x] Tests added/passed ## Validation Steps Performed * Test passes in Debug builds ✅ (cherry picked from commit 5072ee6)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WideCharToMultiBytedoesn't write a final null-byte by default.til::u16u8avoids the problem.PR Checklist
Validation Steps Performed