Fix various issues with useBackgroundImageForWindow #13090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Settings
lhecker
commented
May 12, 2022
| if (imageSource == nullptr || | ||
| imageSource.UriSource() == nullptr || | ||
| imageSource.UriSource().RawUri() != imageUri.RawUri()) | ||
| !imageSource.UriSource().Equals(imageUri)) |
Member
Author
There was a problem hiding this comment.
RawUri() returns the string the URI was constructed with, not the normalized variant.
This can result in imageSource.UriSource().RawUri() being file:///C:/..., while imageUri.RawUri() is C:\\....
DHowett
reviewed
May 12, 2022
| void TerminalPage::_SetBackgroundImage(const winrt::Microsoft::Terminal::Settings::Model::IAppearanceConfig& newAppearance) | ||
| { | ||
| if (newAppearance.BackgroundImagePath().empty()) | ||
| const auto path = newAppearance.ExpandedBackgroundImagePath(); |
DHowett
approved these changes
May 12, 2022
carlos-zamora
approved these changes
May 12, 2022
Member
|
@msftbot merge this in 5 minutes |
ghost
added
the
AutoMerge
|
Hello @carlos-zamora! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
ghost
merged commit
carlos-zamora
pushed a commit
that referenced
this pull request
May 12, 2022
Fixes the following issues: * `desktopWallpaper` not working * switching tabs/panes causes the background to flicker * settings preview having a transparent background ## PR Checklist * [x] Closes #13002 * [x] I work here * [x] Tests added/passed ## Validation Steps Performed Tested the 3 cases above. ✅ (cherry picked from commit 0630b18) Service-Card-Id: 81868221 Service-Version: 1.14
5 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following issues:
desktopWallpapernot workingPR Checklist
Validation Steps Performed
Tested the 3 cases above. ✅