Skip to content

Conversation

@lhecker
Copy link
Member

@lhecker lhecker commented Jun 9, 2022

ed27737 contains a regression where (pseudocode)

unsigned long ulActualDelta;
short ScreenInfo.WheelDelta;
delta *= (ScreenInfo.WheelDelta / (short)ulActualDelta);
//                                ^^^^^^^

was changed to

delta *= (ScreenInfo.WheelDelta / ulActualDelta);

Due to ulActualDelta being unsigned, the new code casts the signed integer
to a unsigned one first, before doing the division. This causes scrolling
downwards (WheelDelta is negative) to appear as a large positive delta.

PR Checklist

Validation Steps Performed

  • Scrolling up/down works in OpenConsole again ✅

@ghost ghost added Area-Input Related to input processing (key presses, mouse, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Conhost For issues in the Console codebase Severity-Blocking We won't ship a release like this! No-siree. labels Jun 9, 2022
@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jun 9, 2022
@ghost
Copy link

ghost commented Jun 9, 2022

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 3 hours 55 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@DHowett
Copy link
Member

DHowett commented Jun 9, 2022

@msftbot merge this in 1 minute

@ghost
Copy link

ghost commented Jun 9, 2022

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Thu, 09 Jun 2022 19:54:40 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 730eb5f into main Jun 9, 2022
@ghost ghost deleted the dev/lhecker/13253-scrolling-bug branch June 9, 2022 19:55
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Input Related to input processing (key presses, mouse, etc.) AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Conhost For issues in the Console codebase Severity-Blocking We won't ship a release like this! No-siree.

Projects

Development

Successfully merging this pull request may close these issues.

Scroll wheel no longer works correctly in OpenConsole

5 participants