Strip XAML files from the MSIX payload #13351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These files are vestigial, because we are also shipping (either as loose files or embedded in resources.pri) precompiled xbf/xaml binary format files. This saves us almost 500kb on disk. Fixes #11687
ghost
added
the
dmachaj
approved these changes
Jun 21, 2022
zadjii-msft
approved these changes
Jun 21, 2022
Contributor
|
Are we able to modify these xbf files? For those of us who don't agree with Win11 style UI and revert to the Win10, the Xaml files were pretty convenient way of doing so. |
Member
|
... I don't think the .xaml files in the package were ever being used. The Terminal should have always been directly referencing the pre-compiled .xbf's. Were you successfully modifying the Terminal's xaml by manually editing the xaml files before? If so - how? |
Member
Author
|
Yeah, that's quite surprising. There's a number of issues with that approach.
|
Member
Author
|
(I totally get why you feel that way, btw, and I wanted to thank you for sharing your use case!) |
DHowett
added a commit
that referenced
this pull request
Jun 30, 2022
These files are vestigial, because we are also shipping (either as loose files or embedded in resources.pri) precompiled xbf/xaml binary format files. This saves us almost 500kb on disk. Fixes #11687 Validation ---------- I ran a local build and saw that it produced a working Terminal, packaged and unpackaged. (cherry picked from commit 0b97c7b) Service-Card-Id: 83425307 Service-Version: 1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These files are vestigial, because we are also shipping (either as loose
files or embedded in resources.pri) precompiled xbf/xaml binary format
files.
This saves us almost 500kb on disk.
Fixes #11687
Validation
I ran a local build and saw that it produced a working Terminal, packaged
and unpackaged.