Skip to content

Conversation

@PankajBhojwani
Copy link
Contributor

@PankajBhojwani PankajBhojwani commented Aug 1, 2022

Summary of the Pull Request

  • When 'discard changes' is hit, we re-initialize our list of color scheme view models but forgot to tell xaml about it, this commit fixes that.
  • Make sure to exit rename mode when 'update settings' gets called

References

color schemes mvvm added in #13179

PR Checklist

  • CLA signed. If not, go over here and sign the CLA
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Validation Steps Performed

Hitting discard changes doesn't cause an inconsistency with the currently selected scheme anymore

@github-actions

This comment has been minimized.

@PankajBhojwani PankajBhojwani changed the title tell xaml the list changed too Fix an issue with color scheme MVVM Aug 1, 2022
@PankajBhojwani PankajBhojwani marked this pull request as ready for review August 1, 2022 18:27
@PankajBhojwani PankajBhojwani marked this pull request as draft August 1, 2022 18:38
@zadjii-msft
Copy link
Member

Sorry for busting spellbot, merging main should fix this

@PankajBhojwani PankajBhojwani changed the title Fix an issue with color scheme MVVM Fix a couple of issues with color scheme MVVM Aug 1, 2022
@PankajBhojwani PankajBhojwani marked this pull request as ready for review August 1, 2022 19:48
@carlos-zamora carlos-zamora added the Needs-Second It's a PR that needs another sign-off label Aug 1, 2022
@ghost ghost requested review from DHowett, lhecker and zadjii-msft August 1, 2022 20:04
@zadjii-msft zadjii-msft added this to the Terminal v1.16 milestone Aug 1, 2022
@zadjii-msft
Copy link
Member

@msftbot merge this like yesterday

@ghost
Copy link

ghost commented Aug 1, 2022

Hello @zadjii-msft!

I think you told me that you would like to reset custom auto-merge settings, but I am not confident that I have understood you correctly.

Please try rephrasing your instruction to me.

@zadjii-msft
Copy link
Member

boo

@msftbot merge this in 1 minute

@carlos-zamora carlos-zamora added the AutoMerge Marked for automatic merge by the bot when requirements are met label Aug 2, 2022
@ghost
Copy link

ghost commented Aug 2, 2022

Hello @carlos-zamora!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 1 hour 15 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 7976e48 into main Aug 2, 2022
@ghost ghost deleted the dev/pabhoj/fix_csvm branch August 2, 2022 02:23
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AutoMerge Marked for automatic merge by the bot when requirements are met Needs-Second It's a PR that needs another sign-off

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants