Use float throughout ColorFix #14266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
the
Area-CodeHealth
Member
hm. |
DHowett
approved these changes
Oct 24, 2022
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
DHowett
pushed a commit
that referenced
this pull request
Dec 12, 2022
This is just a quick drive-by improvement. Switching from double to float roughly doubles performance on a contemporary x86 CPU with `/fp:fast`. ## Validation Steps Performed * Patch `RenderSettings.hpp` to include `Mode::AlwaysDistinguishableColors` * Run a color intense application in AtlasEngine and observe CPU usage (cherry picked from commit bbc14a0) Service-Card-Id: 87207829 Service-Version: 1.15
DHowett
pushed a commit
that referenced
this pull request
Dec 12, 2022
This is just a quick drive-by improvement. Switching from double to float roughly doubles performance on a contemporary x86 CPU with `/fp:fast`. ## Validation Steps Performed * Patch `RenderSettings.hpp` to include `Mode::AlwaysDistinguishableColors` * Run a color intense application in AtlasEngine and observe CPU usage (cherry picked from commit bbc14a0) Service-Card-Id: 87207830 Service-Version: 1.16
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a quick drive-by improvement. Switching from double to float
roughly doubles performance on a contemporary x86 CPU with
/fp:fast.Validation Steps Performed
RenderSettings.hppto includeMode::AlwaysDistinguishableColors