-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Update to check-spelling v0.0.21 #14455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
| <PGOPackageName>Microsoft.Internal.Windows.Terminal.PGODatabase</PGOPackageName> | ||
|
|
||
| <!-- Mandatory. Major version number of the PGO database which should match the version of the product. This can be hardcoded or obtained from other sources in build system. --> | ||
| <!-- Mandatory. Major version number of the PGO database which should match the version of the product. This can be hard-coded or obtained from other sources in build system. --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's wrong with hardcoded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most dictionaries distinguish between nouns and verbs ... Typically the noun loses the - and the verb / tenses don't.
E.g. setup (n). to set up (v).
Dictionary
Definitions from Oxford Languages · Learn more
Search for a word
hard-code
/härd kōd/
verb COMPUTING
past tense: hard-coded; past participle: hard-coded
I'm happy to drop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
English isn't my first language so I was a bit surprised about this. I was looking up whether there are any rules to forming compound words in English and the Cambridge dictionary says:
We usually make compound nouns with a noun + noun, with a verb (or a word made from a verb) + noun, or with an adjective + noun
Since hard-code is a adjective + verb, I suppose the dash is the right choice at all times?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait... English considers words with a dash as proper compound words? As a German, I find that rather pathetic. 😏 Rechtsschutzversicherungsgesellschaften. 👻
DHowett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am OK with hard-coded. @jsoref thank you for always being on top of this stuff -- thanks entirely to you the spelling on our repository remains passable 😄
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Apologies, I am afraid I am encountering technical difficulties that might have hampered my ability to assist with merging this pull request. I will continue to try to assist if there are further changes to this pull request. |
|
Thanks. You're going to want to reenable the workflow :) |
|
closes #14037 |
|
indeed, i'm going to reflect the changes to all open branches first (: |
|
thanks @floh96 |
|
Well, it turns out that we have 335 branches. Good lord. They've all been updated to check-spelling@v0.0.21. Thanks again! |
Upgrades check-spelling to v0.0.21
The command to apply changes should now work on Windows (it requires
Perl, but I believe that's more or less present most of the time, and it
should walk you through the rest of the required tools).
There are a bunch of new features, the most important here are probably
being able to update the metadata from Windows. (If it doesn't work,
please @ me).
Also, candidate.patterns will automatically suggest patterns. You can
see them in patterns.txt, e.g.:
The metadata bits (the hit count/file count) don't have to be retained
(I hope they'll be useful in deciding whether/or not to add a pattern,
i.e. "how applicable is it?"), the comment hinting at what the pattern
does is probably worth retaining.
We've been using more or less this version for a while internally
(including talk-to-bot, and, I do have a pattern that could be used to
let people use that in forks, but, I'm going to skip that for now).
This weekend, I did some cleanup for
act(to run check-spellinglocally), and some minor polish.
You can see the runs I made in
https://github.com/check-spelling/terminal/actions