Skip to content

Conversation

@jsoref
Copy link
Contributor

@jsoref jsoref commented Nov 28, 2022

Upgrades check-spelling to v0.0.21

The command to apply changes should now work on Windows (it requires
Perl, but I believe that's more or less present most of the time, and it
should walk you through the rest of the required tools).

There are a bunch of new features, the most important here are probably
being able to update the metadata from Windows. (If it doesn't work,
please @ me).

Also, candidate.patterns will automatically suggest patterns. You can
see them in patterns.txt, e.g.:

# Automatically suggested patterns
# hit-count: 3831 file-count: 582
# IServiceProvider
\bI(?=(?:[A-Z][a-z]{2,})+\b)

The metadata bits (the hit count/file count) don't have to be retained
(I hope they'll be useful in deciding whether/or not to add a pattern,
i.e. "how applicable is it?"), the comment hinting at what the pattern
does is probably worth retaining.

We've been using more or less this version for a while internally
(including talk-to-bot, and, I do have a pattern that could be used to
let people use that in forks, but, I'm going to skip that for now).

This weekend, I did some cleanup for act (to run check-spelling
locally), and some minor polish.

You can see the runs I made in
https://github.com/check-spelling/terminal/actions

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
<PGOPackageName>Microsoft.Internal.Windows.Terminal.PGODatabase</PGOPackageName>

<!-- Mandatory. Major version number of the PGO database which should match the version of the product. This can be hardcoded or obtained from other sources in build system. -->
<!-- Mandatory. Major version number of the PGO database which should match the version of the product. This can be hard-coded or obtained from other sources in build system. -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's wrong with hardcoded?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most dictionaries distinguish between nouns and verbs ... Typically the noun loses the - and the verb / tenses don't.

E.g. setup (n). to set up (v).

Dictionary
Definitions from Oxford Languages · Learn more
Search for a word
hard-code
/härd kōd/
verb COMPUTING
past tense: hard-coded; past participle: hard-coded

I'm happy to drop.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

English isn't my first language so I was a bit surprised about this. I was looking up whether there are any rules to forming compound words in English and the Cambridge dictionary says:

We usually make compound nouns with a noun + noun, with a verb (or a word made from a verb) + noun, or with an adjective + noun

Since hard-code is a adjective + verb, I suppose the dash is the right choice at all times?

Copy link
Member

@lhecker lhecker Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait... English considers words with a dash as proper compound words? As a German, I find that rather pathetic. 😏 Rechtsschutzversicherungsgesellschaften. 👻

Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am OK with hard-coded. @jsoref thank you for always being on top of this stuff -- thanks entirely to you the spelling on our repository remains passable 😄

@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Nov 28, 2022
@ghost
Copy link

ghost commented Nov 28, 2022

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@DHowett DHowett changed the title Check spelling 0.0.21 Update to check-spelling v0.0.21 Nov 28, 2022
@ghost
Copy link

ghost commented Nov 28, 2022

Apologies, I am afraid I am encountering technical difficulties that might have hampered my ability to assist with merging this pull request. I will continue to try to assist if there are further changes to this pull request.

@DHowett DHowett merged commit a7ab175 into microsoft:main Nov 28, 2022
@jsoref jsoref deleted the check-spelling-0.0.21 branch November 28, 2022 19:36
@jsoref
Copy link
Contributor Author

jsoref commented Nov 28, 2022

Thanks. You're going to want to reenable the workflow :)

@floh96
Copy link
Contributor

floh96 commented Nov 28, 2022

closes #14037

@DHowett
Copy link
Member

DHowett commented Nov 28, 2022

indeed, i'm going to reflect the changes to all open branches first (:

@DHowett
Copy link
Member

DHowett commented Nov 28, 2022

thanks @floh96

@DHowett
Copy link
Member

DHowett commented Nov 28, 2022

Well, it turns out that we have 335 branches. Good lord. They've all been updated to check-spelling@v0.0.21. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AutoMerge Marked for automatic merge by the bot when requirements are met

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants