PGO: Update the Helix payload to rely on the unpackaged distribution #15123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unpackaged distribution was made for this exact use, so let's *do it*!
Member
Author
|
The PGO build is marked as failed because I cancelled it after it produced pgc files properly. 😄 |
DHowett
changed the title
Member
Author
|
This leaves the localtests broken in Helix, which I'll get to afterwards. |
zadjii-msft
approved these changes
Apr 6, 2023
lhecker
approved these changes
Apr 6, 2023
| # Extract the unpackaged distribution of Windows Terminal to the payload directory, | ||
| # where it will create a subdirectory named terminal-0.0.1.0 | ||
| # This is referenced in TerminalApp.cs later as part of the test harness. | ||
| & tar -x -v -f "$repoDirectory\Artifacts\$ArtifactName\unpackaged\WindowsTerminalDev_0.0.1.0_x64.zip" -C "$payloadDir" |
Member
There was a problem hiding this comment.
I think --full options are better for CI scripts for clarity.
Member
Author
There was a problem hiding this comment.
ah so, the canonical options for tar are the short ones. windows tar doesn't support the GNU-style modern --long-options :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unpackaged distribution was made for this exact use, so let's do it!