Only try to hand off to ConhostV1 if building for Windows #15131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of our automated tooling detects this as being a private API that we're accessing via LoadLibrary/GetProcAddress. It's not *wrong*, but it's also not *right*. It's easier for us to just not do it (and save all the code for it!) in OpenConsole.
lhecker
approved these changes
Apr 6, 2023
zadjii-msft
approved these changes
Apr 6, 2023
Member
|
man this is bodge |
DHowett
added a commit
that referenced
this pull request
Apr 14, 2023
Some of our automated tooling detects this as being a private API that we're accessing via LoadLibrary/GetProcAddress. It's not *wrong*, but it's also not *right*. It's easier for us to just not do it (and save all the code for it!) in OpenConsole. (cherry picked from commit 7fbd3be) Service-Card-Id: 88788306 Service-Version: 1.17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of our automated tooling detects this as being a private API that we're accessing via LoadLibrary/GetProcAddress. It's not wrong, but it's also not right.
It's easier for us to just not do it (and save all the code for it!) in OpenConsole.