AtlasEngine: Fix multiple minor issues #15357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Issue-Bug
lhecker
force-pushed
the
dev/lhecker/atlas-engine-fixup
branch
from
952ed38 to
2140985
Compare
DHowett
approved these changes
May 15, 2023
PankajBhojwani
approved these changes
May 15, 2023
DHowett
pushed a commit
that referenced
this pull request
May 15, 2023
This commit fixes 3 bugs that I found while working on another feature: * `GetGlyphIndices` doesn't return an error when the codepoint couldn't be found, it simply returns a glyph index of 0. * `_resetGlyphAtlas` failed to reset the `linear_flat_set` "load" to 0 which would result in an unbounded memory growth over time. * `linear_flat_set` was missing move constructors/operators, which would've led to crashes, etc., but thankfully we haven't made use of these operators yet. But better fix it now than never. (cherry picked from commit af5a6ea) Service-Card-Id: 89210623 Service-Version: 1.18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes 3 bugs that I found while working on another feature:
GetGlyphIndicesdoesn't return an error when the codepoint couldn'tbe found, it simply returns a glyph index of 0.
_resetGlyphAtlasfailed to reset thelinear_flat_set"load" to 0which would result in an unbounded memory growth over time.
linear_flat_setwas missing move constructors/operators, whichwould've led to crashes, etc., but thankfully we haven't made use
of these operators yet. But better fix it now than never.