Various fixes and improvements for ConsoleTypes.natvis #15543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
the
Area-CodeHealth
lhecker
commented
Jun 13, 2023
| <Item Name="scratchpad">*(ROW*)_buffer.__ptr_.__value_</Item> | ||
| <IndexListItems> | ||
| <Size>(_commitWatermark - _buffer.__ptr_.__value_ - 1) / _bufferRowStride</Size> | ||
| <ValueNode>*(ROW*)(_buffer.__ptr_.__value_ + _bufferRowStride * ($i + 1))</ValueNode> |
Member
Author
There was a problem hiding this comment.
Even if I add the wil.natvis file to our project I can't get the get() function to work without VS complaining about it having side effects. It works fine in a watch window, so I think this is a problem with a natvis file not being able to reference another file? But why do STL types work then? I don't entirely get it...
In any case, this works. It's ugly but it works.
carlos-zamora
approved these changes
Jun 13, 2023
microsoft-github-policy-service
bot
requested review from
DHowett,
PankajBhojwani,
carlos-zamora and
zadjii-msft
DHowett
approved these changes
Jun 13, 2023
microsoft-github-policy-service
bot
removed
the
Needs-Second
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the broken types for
TextAttribute,til::size,til::pointand
til::rectand adds a new type forTextBufferwhich withoutthis would now be much harder to inspect due to introduction of
the manual virtual memory management in 612b00c.