Skip to content

Conversation

@suravshrestha
Copy link

Summary of the Pull Request

This PR fixes typos in oss/chromium/base/numerics/README.md

References and Relevant Issues

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

PR Checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated
    • If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated (if necessary)

@KalleOlaviNiemitalo
Copy link

That file was copied from Chromium. I don't think it should be edited in this repository. Instead, the typos should be fixed in https://github.com/chromium/chromium/blob/master/base/numerics/README.md and then the whole new version copied to this repository again.

@KalleOlaviNiemitalo
Copy link

"Don't change anything about it" in the instructions:

## What should be done to update this in the future?
1. Go to chromium/chromium repository on GitHub.
2. Take the entire contents of the base/numerics directory wholesale and drop it in the base/numerics directory here.
3. Don't change anything about it.
4. Validate that the license in the root of the repository didn't change and update it if so. It is sitting in the same directory as this readme.
If it changed dramatically, ensure that it is still compatible with our license scheme. Also update the NOTICE file in the root of our repository to declare the third-party usage.
5. Submit the pull.

@zadjii-msft
Copy link
Member

Yep. Everything in oss/ and dep/ should be fixed upstream, then we can ingest those updates.

@KalleOlaviNiemitalo KalleOlaviNiemitalo mentioned this pull request Oct 15, 2023
@zadjii-msft zadjii-msft added the spam thought we wouldn't notice, but we did label Oct 17, 2023
@suravshrestha
Copy link
Author

@zadjii-msft This is my first participation in Hacktoberfest. Labeling this pull request as spam will disqualify me from the event. I assure you that this won't happen in the future, and I kindly ask for your help in reviewing and removing the spam label from this PR. Your assistance is greatly appreciated. Thank you for your time and consideration. ❤️

@zadjii-msft zadjii-msft mentioned this pull request Oct 26, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

spam thought we wouldn't notice, but we did

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants