Updated SettingsSchema.md with default values for global and profiles #1784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett-MSFT
approved these changes
Jul 3, 2019
| | `fontSize` | _Required_ | Integer | `10` | Sets the font size. | | ||
| | `guid` | _Required_ | String | | Unique identifier of the profile. Written in registry format: `"{00000000-0000-0000-0000-000000000000}"`. | | ||
| | `historySize` | _Required_ | Integer | `9001` | The number of lines above the ones displayed in the window you can scroll back to. | | ||
| | `name` | _Required_ | String | `PowerShell Core` | Name of the profile. Displays in the dropdown menu. | |
Contributor
There was a problem hiding this comment.
There is no default here really
Contributor
Author
There was a problem hiding this comment.
Should I keep PowerShell guid in globals for defaultProfile?
Contributor
|
How does this close #1753 though |
Contributor
Author
Oops, you're right! Fixing issue number now 😊 |
zadjii-msft
approved these changes
Jul 3, 2019
miniksa
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Added default values for global and profiles within SettingsSchema.md
References
#1712
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed