Skip to content

Conversation

@PankajBhojwani
Copy link
Contributor

@PankajBhojwani PankajBhojwani commented Jan 30, 2026

Summary of the Pull Request

  • Actions page: entries now stretch across the screen horizontally (to a max of 1000) to be consistent with other settings pages
  • Edit action page:
  • Keybindings and Additional arguments are now top-aligned headers
  • All arg templates now also stretch across the screen horizontally or are right-aligned to match how expanders look in the rest of the settings UI (the one exception being the color picker - this one looks weird right-aligned)

Validation Steps Performed

Everything still works. Screenshots below.

PR Checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated
    • If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated (if necessary)

@@ -0,0 +1,7 @@
{

Check failure

Code scanning / check-spelling

Check File Path

[claude](#security-tab) is not a recognized word. \(check-file-path\)

DirectX presents the frame to the display:
```cpp
_swapChain->Present(1, 0); // Vsync enabled

Check failure

Code scanning / check-spelling

Unrecognized Spelling

[Vsync](#security-tab) is not a recognized word. \(unrecognized-spelling\)
### Middle of Line

```
Before: "He█llo" (cursor after 'e')

Check failure

Code scanning / check-spelling

Unrecognized Spelling

[llo](#security-tab) is not a recognized word. \(unrecognized-spelling\)
```
Before: "He█llo" (cursor after 'e')
Press Backspace
After: "H█llo" (cursor after 'H')

Check failure

Code scanning / check-spelling

Unrecognized Spelling

[llo](#security-tab) is not a recognized word. \(unrecognized-spelling\)
```
\x1b[D ← Move cursor left
\x1b[K ← Erase to end
llo ← Rewrite remaining text

Check failure

Code scanning / check-spelling

Unrecognized Spelling

[llo](#security-tab) is not a recognized word. \(unrecognized-spelling\)
- **curses** - Python bindings for ncurses

**Rust:**
- **termion** - Terminal manipulation

Check failure

Code scanning / check-spelling

Unrecognized Spelling

[termion](#security-tab) is not a recognized word. \(unrecognized-spelling\)

**Rust:**
- **termion** - Terminal manipulation
- **crossterm** - Cross-platform terminal library

Check failure

Code scanning / check-spelling

Unrecognized Spelling

[crossterm](#security-tab) is not a recognized word. \(unrecognized-spelling\)
│ └──────────────────────────────────────┘ │
│ │
│ DirectX 11 Pipeline: │
│ 1. Rasterize glyphs with DirectWrite │

Check failure

Code scanning / check-spelling

Unrecognized Spelling

[Rasterize](#security-tab) is not a recognized word. \(unrecognized-spelling\)
IRenderEngine::PaintBufferLine()
AtlasEngine:
• Looks up/rasterizes glyphs

Check failure

Code scanning / check-spelling

Unrecognized Spelling

[rasterizes](#security-tab) is not a recognized word. \(unrecognized-spelling\)
- `IRenderData` for rendering data access
- `IRenderEngine` for rendering backend abstraction
- `ITerminalInput` for input handling
- Enables pluggability and testability

Check failure

Code scanning / check-spelling

Unrecognized Spelling

[pluggability](#security-tab) is not a recognized word. \(unrecognized-spelling\)
@PankajBhojwani
Copy link
Contributor Author

image

narrow:
image

Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new layout. The headers look nice and make it clear that there's different sections.

I think the spacing needs to be adjusted a little bit though. Here's some notes:

  • Spacing:
    • spacing beneath headers (i.e. "Command details", "Keybindings", and "Additional arguments") is a little too large. Looks like it's ~40 for "command details" and "additional arguments", but ~24 for "Keybindings".
      • I recommend ~12 (WinUI 3 gallery says "12 - between control + header, surface and edge text, text sections")
    • Spacing between keybinding and "Additional arguments" is ~26.
      • I recommend ~16 (WinUI 3 gallery says "16 - used in list styles, cards")
    • Spacing between "action name" and "action type" (and repeat for spacing between keybindings and each arg) is currently ~16 (~8 for keybindings and additional args)
      • I recommend ~8 consistently. I think keybindings and additional args look good as-is, so I'm kinda getting inspiration from there.
  • Alignment:
    • delete button for keybindings feels really far away haha
      • recommendation: left align them. Maybe have it be a grid with 2 columns (key chords vs delete buttons) so that the delete buttons themselves are aligned with each other
    • nit: "action name" and "action type" controls are aligned (nice), but they don't align with the ones in "additional arguments". Might be nice if they did?
    • consider aligning the checkbox action args to the left. They feel a bit far away too haha.
  • Order:
    • Consider moving the "add keybinding" button to after the key chords (instead of before).

All that said, I'm not a designer haha. I think these might be a good starting point though and you can adjust them from there?

I found a few resources that may be helpful:

Hope this all helps!

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants