-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Update actions page and edit actions page with better alignment #19822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
.claude/settings.local.json
Outdated
| @@ -0,0 +1,7 @@ | |||
| { | |||
Check failure
Code scanning / check-spelling
Check File Path
Backspace_Flow_Explained.md
Outdated
|
|
||
| DirectX presents the frame to the display: | ||
| ```cpp | ||
| _swapChain->Present(1, 0); // Vsync enabled |
Check failure
Code scanning / check-spelling
Unrecognized Spelling
Backspace_Flow_Explained.md
Outdated
| ### Middle of Line | ||
|
|
||
| ``` | ||
| Before: "He█llo" (cursor after 'e') |
Check failure
Code scanning / check-spelling
Unrecognized Spelling
Backspace_Flow_Explained.md
Outdated
| ``` | ||
| Before: "He█llo" (cursor after 'e') | ||
| Press Backspace | ||
| After: "H█llo" (cursor after 'H') |
Check failure
Code scanning / check-spelling
Unrecognized Spelling
Backspace_Flow_Explained.md
Outdated
| ``` | ||
| \x1b[D ← Move cursor left | ||
| \x1b[K ← Erase to end | ||
| llo ← Rewrite remaining text |
Check failure
Code scanning / check-spelling
Unrecognized Spelling
VT_Sequences_Explained.md
Outdated
| - **curses** - Python bindings for ncurses | ||
|
|
||
| **Rust:** | ||
| - **termion** - Terminal manipulation |
Check failure
Code scanning / check-spelling
Unrecognized Spelling
VT_Sequences_Explained.md
Outdated
|
|
||
| **Rust:** | ||
| - **termion** - Terminal manipulation | ||
| - **crossterm** - Cross-platform terminal library |
Check failure
Code scanning / check-spelling
Unrecognized Spelling
WindowsTerminal_Architecture.md
Outdated
| │ └──────────────────────────────────────┘ │ | ||
| │ │ | ||
| │ DirectX 11 Pipeline: │ | ||
| │ 1. Rasterize glyphs with DirectWrite │ |
Check failure
Code scanning / check-spelling
Unrecognized Spelling
WindowsTerminal_Architecture.md
Outdated
| IRenderEngine::PaintBufferLine() | ||
| ↓ | ||
| AtlasEngine: | ||
| • Looks up/rasterizes glyphs |
Check failure
Code scanning / check-spelling
Unrecognized Spelling
WindowsTerminal_Architecture.md
Outdated
| - `IRenderData` for rendering data access | ||
| - `IRenderEngine` for rendering backend abstraction | ||
| - `ITerminalInput` for input handling | ||
| - Enables pluggability and testability |
Check failure
Code scanning / check-spelling
Unrecognized Spelling
carlos-zamora
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new layout. The headers look nice and make it clear that there's different sections.
I think the spacing needs to be adjusted a little bit though. Here's some notes:
- Spacing:
- spacing beneath headers (i.e. "Command details", "Keybindings", and "Additional arguments") is a little too large. Looks like it's ~40 for "command details" and "additional arguments", but ~24 for "Keybindings".
- I recommend ~12 (WinUI 3 gallery says "12 - between control + header, surface and edge text, text sections")
- Spacing between keybinding and "Additional arguments" is ~26.
- I recommend ~16 (WinUI 3 gallery says "16 - used in list styles, cards")
- Spacing between "action name" and "action type" (and repeat for spacing between keybindings and each arg) is currently ~16 (~8 for keybindings and additional args)
- I recommend ~8 consistently. I think keybindings and additional args look good as-is, so I'm kinda getting inspiration from there.
- spacing beneath headers (i.e. "Command details", "Keybindings", and "Additional arguments") is a little too large. Looks like it's ~40 for "command details" and "additional arguments", but ~24 for "Keybindings".
- Alignment:
- delete button for keybindings feels really far away haha
- recommendation: left align them. Maybe have it be a grid with 2 columns (key chords vs delete buttons) so that the delete buttons themselves are aligned with each other
- nit: "action name" and "action type" controls are aligned (nice), but they don't align with the ones in "additional arguments". Might be nice if they did?
- consider aligning the checkbox action args to the left. They feel a bit far away too haha.
- delete button for keybindings feels really far away haha
- Order:
- Consider moving the "add keybinding" button to after the key chords (instead of before).
All that said, I'm not a designer haha. I think these might be a good starting point though and you can adjust them from there?
I found a few resources that may be helpful:
- WinUI 3 Gallery > Spacing page
- https://learn.microsoft.com/en-us/windows/apps/design/basics/content-basics
Hope this all helps!


Summary of the Pull Request
KeybindingsandAdditional argumentsare now top-aligned headersValidation Steps Performed
Everything still works. Screenshots below.
PR Checklist