Standardize use of NavigateToPageArgs in SUI#19831
Open
carlos-zamora wants to merge 1 commit intomainfrom
Open
Standardize use of NavigateToPageArgs in SUI#19831carlos-zamora wants to merge 1 commit intomainfrom
carlos-zamora wants to merge 1 commit intomainfrom
Conversation
Member
Author
|
Fun fact: GH Copilot was super useful here. I was actually able to point it to #19519 and tell it to port the specific change over. It was like 80% successful (it wanted to refactor at one point for some reason). |
DHowett
reviewed
Feb 6, 2026
| #include "EnumEntry.h" | ||
| #include "Compatibility.g.cpp" | ||
| #include "CompatibilityViewModel.g.cpp" | ||
| #include "NavigateToPageArgs.g.h" |
Member
There was a problem hiding this comment.
we shouldn't need the .g.h guys here - but if we do, please move them ABOVE the cpp files.
in general, these should come in auto-included via the Microsoft.Terminal.Settings.Editor.h top-level projection type #include
DHowett
reviewed
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Replaces usage of
NavigateToXArgsin theTerminalSettingsEditorwithNavigateToPageArgs. They all did pretty much the same thing anyways.References and Relevant Issues
Builds on #19826
Pulled out from #19519
Validation Steps Performed
✅ Navigated through all the SUI pages and subpages