Send notifications even when we're unpackaged#20013
Merged
carlos-zamora merged 2 commits intodev/cazamor/toast/basefrom Mar 25, 2026
Merged
Send notifications even when we're unpackaged#20013carlos-zamora merged 2 commits intodev/cazamor/toast/basefrom
carlos-zamora merged 2 commits intodev/cazamor/toast/basefrom
Conversation
DHowett
reviewed
Mar 25, 2026
| // and toast notifications may not be supported without additional setup. | ||
| auto notifier = ToastNotificationManager::CreateToastNotifier(); | ||
| notifier.Show(toast); | ||
| // For unpackaged apps, we must pass the explicit AUMID that was registered |
Member
There was a problem hiding this comment.
If you make the other block a separate PR to main, you can fold this one into #20010
lhecker
reviewed
Mar 25, 2026
Comment on lines
+117
to
+118
| if (notifier) | ||
| { |
Member
There was a problem hiding this comment.
Do those WinRT (?) functions really return null instead of throwing an HRESULT?
Member
Author
There was a problem hiding this comment.
Not sure if CreateToastNotifier() can return null, but I have trust issues haha.
It's more there for when this fails...
if (SUCCEEDED(GetCurrentProcessExplicitAppUserModelID(&aumid)))
carlos-zamora
force-pushed
the
dev/cazamor/toast/base
branch
from
4357c17 to
aeb531f
Compare
carlos-zamora
force-pushed
the
dev/cazamor/toast/unpackaged
branch
from
6d8466e to
fc1b724
Compare
Member
Author
|
PR has been updated to move the WindowEmperor changes (unpackaged AUMID) into a separate PR targettng Merging this PR into #20010 as Dustin suggested here: #20013 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Targets #20010
Manually assign an AUMID to our process when we're running unpackaged.
Main difference from #19937 is what AUMID we use. Before, it was per branding, but the
WindowEmperoralready appends an exe path hash for unpackaged instances to prevent crosstalk. Here, we're just using the same pattern:Microsoft.WindowsTerminal.<hash>.Heavily based on #19937
Co-authored by @zadjii-msft