Show hand cursor when Ctrl-hovering hyperlinks#20102
Open
bcullman wants to merge 3 commits intomicrosoft:mainfrom
Open
Show hand cursor when Ctrl-hovering hyperlinks#20102bcullman wants to merge 3 commits intomicrosoft:mainfrom
bcullman wants to merge 3 commits intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
Author
Member
|
Don't worry, all of the right people already get notifications for pull requests :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Show a hand cursor when the user holds
Ctrlwhile hovering a hyperlink in Windows Terminal.References and Relevant Issues
Closes #7563
Detailed Description of the Pull Request / Additional comments
This change updates
TermControlto temporarily override the pointer cursor with a hand cursor when all of the following are true:Ctrlis pressedThe cursor override is refreshed on pointer movement and on
Ctrlkey transitions, so pressing or releasingCtrlwhile the mouse remains stationary over a hyperlink updates the cursor immediately.The previous cursor is restored when the condition no longer applies, including on:
This keeps the existing hyperlink activation behavior unchanged: links still open with
Ctrl+Click.Validation Steps Performed
src/cascadia/UnitTests_Control/Control.UnitTests.vcxprojControl.Unit.Tests.dllsuccessfullyWindowsTerminal.exelocallyCtrldoes not show a hand cursorCtrlwhile hovering a hyperlink switches to the hand cursor immediatelyCtrlrestores the previous cursor immediatelyCtrl+Clickstill opens the hyperlinkCtrlremains pressed, the cursor reverts from hand to normalPR Checklist