Revert "Implement OSC 7 for setting the CWD (#20019)"#20116
Merged
DHowett merged 1 commit intorelease-1.25from Apr 15, 2026
Merged
Revert "Implement OSC 7 for setting the CWD (#20019)"#20116DHowett merged 1 commit intorelease-1.25from
DHowett merged 1 commit intorelease-1.25from
Conversation
This reverts commit 7f5185e.
Member
Author
carlos-zamora
approved these changes
Apr 15, 2026
Member
carlos-zamora
left a comment
carlos-zamora
left a comment
There was a problem hiding this comment.
Clean revert. Hopefully we can figure out a way to implement it still. Thanks to you and Leonard for working on this :)
Comment on lines
+868
to
+869
| // TODO: Add support for OSC 7 = CWD sequences? | ||
| // In GH#8214 it was decided that it's a bad idea due to WSL compat. |
Member
There was a problem hiding this comment.
funny that we're reverting it due to WSL compat 😆
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 7f5185e.
I have some new concerns about the fix in #20094, so I'm considering reverting OSC 7 from 1.25.
Refs #20108