Refresh check-spelling metadata for v0.0.26#20141
Conversation
| ILCo | ||
| ILD | ||
| ime | ||
| IMEs |
There was a problem hiding this comment.
Don't worry too much about these, after this is merged I'll make another PR that cleans things out (and not the way it's suggesting).
| lpwstr | ||
| LRESULT | ||
| lsb | ||
| LSBs |
| prg | ||
| pri | ||
| prioritization | ||
| PRIs |
| @@ -0,0 +1,40 @@ | |||
| Ccc | |||
| changelists | |||
| pri | ||
| prioritization | ||
| rcv | ||
| screenshots |
85208b4 to
e253dbc
Compare
jsoref
left a comment
There was a problem hiding this comment.
I've had this in progress for a while...
| changelists | ||
| screenshots |
There was a problem hiding this comment.
these items could be removed later (items in expect will eventually cover them)
| @@ -0,0 +1,40 @@ | |||
| Ccc | |||
There was a problem hiding this comment.
It should be possible to delete this file after merging, although it may require an update to config.json to pull in a different set of dictionaries. I'll have to revisit that later...
| "asm": "https://raw.githubusercontent.com/check-spelling/assembly-dictionaries/20231110/", | ||
| "cspell": "https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20241114/dictionaries/", | ||
| "census": "https://raw.githubusercontent.com/check-spelling-sandbox/census/dictionaries-d90e686f89dd241ad61d30f26619e54d73e73c6e/dictionaries/" |
There was a problem hiding this comment.
asm and census are new things that I've been using for a bit in spell-check-this, but haven't shipped as core to check-spelling. For most repositories, census is pretty amazing.
This PR doesn't precisely pull them in, but at least census would be suggested.
There was a problem hiding this comment.
wow, what is census? A list of commonly-used but otherwise "spelled incorrectly" words? I see xargs is on the list, but also vvv
There was a problem hiding this comment.
https://github.com/check-spelling-sandbox/census basically it runs through repositories where I've used check-spelling and counts hits of words in allow/expect -- https://github.com/check-spelling-sandbox/census/blob/d90e686f89dd241ad61d30f26619e54d73e73c6e/census.sh
I tried various cutoffs, but the one I've settled on is if five repositories have used the same word, then it seems on average to be a word that the GitHub community believes in (even if I/the other dictionaries don't).
| "cspell:software-terms/softwareTerms.txt", | ||
| "cspell:cpp/stdlib-cpp.txt", | ||
| "cspell:cpp/stdlib-c.txt", | ||
| "cspell:python/python/python-lib.txt", | ||
| "cspell:php/php.txt", | ||
| "cspell:node/node.txt", | ||
| "cspell:dart/dart.txt", | ||
| "cspell:filetypes/filetypes.txt", | ||
| "cspell:java/java.txt", | ||
| "cspell:css/css.txt", | ||
| "cspell:dotnet/dotnet.txt", | ||
| "cspell:npm/npm.txt", | ||
| "cspell:fullstack/fullstack.txt", | ||
| "cspell:java/java-terms.txt", | ||
| "cspell:r/r.txt", | ||
| "cspell:golang/go.txt", | ||
| "cspell:cpp/stdlib-cmath.txt", | ||
| "cspell:typescript/typescript.txt", | ||
| "cspell:html/html.txt", | ||
| "cspell:cpp/compiler-msvc.txt", | ||
| "cspell:django/django.txt", | ||
| "cspell:aws/aws.txt", | ||
| "cspell:python/common/extra.txt", | ||
| "cspell:cpp/ecosystem.txt", | ||
| "cspell:cpp/lang-keywords.txt", | ||
| "cspell:csharp/csharp.txt", | ||
| "cspell:cpp/compiler-clang-attributes.txt", | ||
| "cspell:python/python/python.txt", | ||
| "cspell:mnemonics/mnemonics.txt", | ||
| "cspell:powershell/powershell.txt", |
There was a problem hiding this comment.
This is the set of dictionaries that are currently used in the workflow. A future commit can switch them to a different set.
For reference, here's the set that check-spelling wants to use (roughly in the order that it suggested items):
| "cspell:software-terms/softwareTerms.txt", | |
| "cspell:cpp/stdlib-cpp.txt", | |
| "cspell:cpp/stdlib-c.txt", | |
| "cspell:python/python/python-lib.txt", | |
| "cspell:php/php.txt", | |
| "cspell:node/node.txt", | |
| "cspell:dart/dart.txt", | |
| "cspell:filetypes/filetypes.txt", | |
| "cspell:java/java.txt", | |
| "cspell:css/css.txt", | |
| "cspell:dotnet/dotnet.txt", | |
| "cspell:npm/npm.txt", | |
| "cspell:fullstack/fullstack.txt", | |
| "cspell:java/java-terms.txt", | |
| "cspell:r/r.txt", | |
| "cspell:golang/go.txt", | |
| "cspell:cpp/stdlib-cmath.txt", | |
| "cspell:typescript/typescript.txt", | |
| "cspell:html/html.txt", | |
| "cspell:cpp/compiler-msvc.txt", | |
| "cspell:django/django.txt", | |
| "cspell:aws/aws.txt", | |
| "cspell:python/common/extra.txt", | |
| "cspell:cpp/ecosystem.txt", | |
| "cspell:cpp/lang-keywords.txt", | |
| "cspell:csharp/csharp.txt", | |
| "cspell:cpp/compiler-clang-attributes.txt", | |
| "cspell:python/python/python.txt", | |
| "cspell:mnemonics/mnemonics.txt", | |
| "cspell:powershell/powershell.txt", | |
| "cspell:software-terms/softwareTerms.txt", | |
| "cspell:cpp/stdlib-c.txt", | |
| "census:census-5.txt", | |
| "cspell:cpp/stdlib-cpp.txt", | |
| "cspell:python/python/python-lib.txt", | |
| "cspell:php/php.txt", | |
| "cspell:dart/dart.txt", | |
| "cspell:css/css.txt", | |
| "cspell:node/node.txt", | |
| "cspell:filetypes/filetypes.txt", | |
| "cspell:npm/npm.txt", | |
| "cspell:java/java.txt", | |
| "cspell:dotnet/dotnet.txt", | |
| "cspell:fullstack/fullstack.txt", | |
| "cspell:java/java-terms.txt", | |
| "cspell:cpp/stdlib-cmath.txt", | |
| "cspell:typescript/typescript.txt", | |
| "cspell:cpp/compiler-msvc.txt", | |
| "cspell:python/common/extra.txt", | |
| "cspell:html/html.txt", | |
| "cspell:golang/go.txt", | |
| "cspell:cpp/ecosystem.txt", | |
| "cspell:powershell/powershell.txt", | |
| "cspell:mnemonics/mnemonics.txt", |
This change could be done in the next PR (but can't be done in this PR w/o getting check-spelling upset).
| followup: ${{ steps.spelling.outputs.followup }} | ||
| runs-on: ubuntu-latest | ||
| if: ${{ contains(github.event_name, 'pull_request') || github.event_name == 'push' }} | ||
| if: ${{ (contains(github.event_name, 'pull_request') && github.event.pull_request.state == 'open') || github.event_name == 'push' }} |
There was a problem hiding this comment.
This is mostly for a feature that isn't active for this repository (checking spelling of PR title/description), but it's harmless.
| runs-on: ubuntu-latest | ||
| runs-on: ubuntu-slim |
There was a problem hiding this comment.
the comment phase no longer needs a checkout and now does very little work, so it doesn't need a full runner.
| contains(github.event.comment.body, '@check-spelling-bot apply') && | ||
| contains(github.event.comment.body, '@check-spelling-bot') && | ||
| contains(github.event.comment.body, 'apply') && |
There was a problem hiding this comment.
this allows copying the message from github step summary which tends to get extra markdown markup...
| "**/packages/**": true, | ||
| }, | ||
| } No newline at end of file | ||
| "sarif-viewer.connectToGithubCodeScanning": "on", |
There was a problem hiding this comment.
VS Code made me do it
|
|
||
| *Potential future:* | ||
| - ~~If no updated console exists, potentially check for registration of a terminal UX that is willing to use the inbox ConPTY bits, start it, and transition to being a PTY instead.~~ | ||
| - ~~If no updated console exists, potentially check for registration of a terminal UX that is willing to use the inbox ConPTY bits, start it, and transition to being a PTY instead.~~ |
There was a problem hiding this comment.
VS Code did this (and many others)
| check_extra_dictionaries: "" | ||
| dictionary_source_prefixes: > | ||
| allow-hunspell: false | ||
| load-config-from: | | ||
| { | ||
| "cspell": "https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20241114/dictionaries/" | ||
| "pr-base-keys": [ | ||
| "" | ||
| ], | ||
| "pr-trusted-keys": [ | ||
| "check_extra_dictionaries", | ||
| "dictionary_source_prefixes", | ||
| "extra_dictionaries", | ||
| "" | ||
| ], | ||
| "": [] | ||
| } | ||
| extra_dictionaries: | |
There was a problem hiding this comment.
The dictionary configuration has moved to config.json to allow smooth upgrades (changing dictionaries as part of a PR).
The allow-hunspell flag is a safety bit. It's a third-party library and this repository doesn't need to use foreign language dictionaries via hunspell.
| \$\d\$[A-ZA-z] | ||
|
|
||
| # src/cascadia/TerminalSettingsEditor/Appearances.cpp | ||
| // Pwease call.* |
There was a problem hiding this comment.
LOL. I'm guessing Leonard wrote this
| "cspell:software-terms/softwareTerms.txt", | ||
| "cspell:cpp/stdlib-cpp.txt", | ||
| "cspell:cpp/stdlib-c.txt", | ||
| "cspell:python/python/python-lib.txt", | ||
| "cspell:php/php.txt", | ||
| "cspell:node/node.txt", | ||
| "cspell:dart/dart.txt", | ||
| "cspell:filetypes/filetypes.txt", | ||
| "cspell:java/java.txt", | ||
| "cspell:css/css.txt", | ||
| "cspell:dotnet/dotnet.txt", | ||
| "cspell:npm/npm.txt", | ||
| "cspell:fullstack/fullstack.txt", | ||
| "cspell:java/java-terms.txt", | ||
| "cspell:r/r.txt", | ||
| "cspell:golang/go.txt", | ||
| "cspell:cpp/stdlib-cmath.txt", | ||
| "cspell:typescript/typescript.txt", | ||
| "cspell:html/html.txt", | ||
| "cspell:cpp/compiler-msvc.txt", | ||
| "cspell:django/django.txt", | ||
| "cspell:aws/aws.txt", | ||
| "cspell:python/common/extra.txt", | ||
| "cspell:cpp/ecosystem.txt", | ||
| "cspell:cpp/lang-keywords.txt", | ||
| "cspell:csharp/csharp.txt", | ||
| "cspell:cpp/compiler-clang-attributes.txt", | ||
| "cspell:python/python/python.txt", | ||
| "cspell:mnemonics/mnemonics.txt", | ||
| "cspell:powershell/powershell.txt", |
| "asm": "https://raw.githubusercontent.com/check-spelling/assembly-dictionaries/20231110/", | ||
| "cspell": "https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20241114/dictionaries/", | ||
| "census": "https://raw.githubusercontent.com/check-spelling-sandbox/census/dictionaries-d90e686f89dd241ad61d30f26619e54d73e73c6e/dictionaries/" |
There was a problem hiding this comment.
wow, what is census? A list of commonly-used but otherwise "spelled incorrectly" words? I see xargs is on the list, but also vvv
|
|
||
| We'll provide a setting that will allow the list of tabs to be presented in either _in-order_ (how the tabs are ordered on the tab bar), or _Most Recently Used Order_ (MRU). MRU means that the tab that the terminal most recently visited will be on the top of the list, and the tab that the terminal has not visited for the longest time will be on the bottom. | ||
|
|
||
| There will be an argument for the `openTabSwitcher` action called `displayOrder`. This can be either `inOrder` or `mruOrder`. Making the setting an argument passed into `openTabSwitcher` would allow the user to have one keybinding to open an MRU Tab Switcher, and different one for the In-Order Tab Switcher. For example: |
There was a problem hiding this comment.
wow, what patten caught this? "-ing the -ing" or something like that?
There was a problem hiding this comment.
No, it was the article-word-article thing (the (...) an)
| // If we DON'T have a color set from the color picker, or the profile's | ||
| // tabColor, but we do have a unfocused color in the theme, use the | ||
| // tabColor, but if we have an unfocused color in the theme, use the |
There was a problem hiding this comment.
("if we don't have .. but we do have .." seems cromulent, but I'm OK with this lateral move in clarity)
e253dbc to
0129a5e
Compare
| 21;97m | ||
| __ROWS:END__ | ||
| __DATA:END__ No newline at end of file | ||
| __DATA:END__ |
There was a problem hiding this comment.
VS Code made me do it. I can change these files w/ vi if that's required...
There was a problem hiding this comment.
I think this script will live with a newline at the end. I hope. I think and hope.
| :: The following ECHO intentionally has 80 spaces to clear the | ||
| :: line any remaining on screen text on call. | ||
| ECHO. | ||
| ECHO. |
There was a problem hiding this comment.
Yuck. I whole-heartedly support VSCode's actions.
There was a problem hiding this comment.
Eep, unfortunately this one is actually documented above (funny enough, on another changed line)
:: The following ECHO intentionally has 80 spaces to clear the
:: line any remaining on screen text on call.
There was a problem hiding this comment.
How about this?
set dot_with_spaces=". z"
echo %dot_with_spaces:z=%I hope this is a valid reference: https://ss64.com/nt/syntax-replace.html -- I don't have a Windows computer handy.
We can pick a slightly better named variable...
There was a problem hiding this comment.
Alright, so, the . is syntactically load bearing in this case. As well, variables set with " in continue to contain the quotes. LOL.
however, I think we can do it like this.
set blank_to_eol= z
echo.%blank_to_eol:z=%There was a problem hiding this comment.
…espace Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Switch from using inline config for dictionaries to `config.json` This allows PRs to change these settings which enables smoother upgrades
0129a5e to
64f61d1
Compare
| SET "SCRIPT_NAME=%~nx0" | ||
| SET BLANK_TO_EOL= z | ||
|
|
||
| :: The following ECHO intentionally has 80 spaces to clear the | ||
| :: line any remaining on screen text on call. | ||
| ECHO. | ||
| ECHO.%BLANK_TO_EOL:z=% |
There was a problem hiding this comment.
It was a royal pain to edit this file.
I can't use dos2unix on it:
dos2unix: Binary symbol 0x1B found at line 390
dos2unix: Skipping binary file src/tools/ansi-color/ansi-color.cmdVSCode as noted wanted to eat the file.
I ended up using:
(head -1498 src/tools/ansi-color/ansi-color.cmd; tail -63 src/tools/ansi-color/ansi-color.cmd) > 0; mv 0 src/tools/ansi-color/ansi-color.cmd
... to duplicate one line and then replaced the line's contents.
(I don't remember how to ask vi to cooperate with files w/ dos line endings / how to insert a ^M...)
I think there's a distinction between:
set a="foo"and
set "a=foo"The latter notation probably would do what we want. -- In fact, we could probably just do:
SET "BLANK_TO_EOL= "And skip all the fancy stuff! But that would require me to remember how this stuff works...
There was a problem hiding this comment.
I think you're right about that. But also, yikes, sorry about how terrible it is to edit.
(FWIW: Ctrl+V Ctrl+M for the last note)
DHowett
left a comment
There was a problem hiding this comment.
All good here! Thanks so much!
Summary of the Pull Request
This is a refresh of spell-check-this, more or less as of https://github.com/check-spelling/spell-check-this/tree/e089393b4e834a8b44d585e684f06d5642537818.
References and Relevant Issues
A number of changes take advantage of features from http://github.com/check-spelling/check-spelling/releases/v0.0.26
load-config-fromwill allow future PRs to switch cleanly w/o the mess that this PR has -- once this merges, theconfig.jsonfile will be used for the three dictionary configuration elements instead of the ones in the workflow.contents: readis no longer needed by the comment jobs as the data is provided by the main jobDetailed Description of the Pull Request / Additional comments
Validation Steps Performed
check-spelling-sandbox#7 (comment) (I integrated the changes it complained about)
PR Checklist