Don't allow overflowing lengths in WM_COPYDATA#20185
Merged
Merged
Conversation
lhecker
approved these changes
May 5, 2026
Qmoony
pushed a commit
to Qmoony/terminal
that referenced
this pull request
May 11, 2026
It is possible to craft a packet whose `len` is `0x80000001`. We should not produce values that do not fit in size_t (on e.g. x86). Reject them summarily.
DHowett
added a commit
that referenced
this pull request
May 12, 2026
It is possible to craft a packet whose `len` is `0x80000001`. We should not produce values that do not fit in size_t (on e.g. x86). Reject them summarily. (cherry picked from commit 8edac5f) Service-Card-Id: PVTI_lADOAF3p4s4BBcTlzgr4enM Service-Version: 1.24
DHowett
added a commit
that referenced
this pull request
May 12, 2026
It is possible to craft a packet whose `len` is `0x80000001`. We should not produce values that do not fit in size_t (on e.g. x86). Reject them summarily. (cherry picked from commit 8edac5f) Service-Card-Id: PVTI_lADOAF3p4s4BQX0-zgr4enI Service-Version: 1.25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is possible to craft a packet whose
lenis0x80000001.We should not produce values that do not fit in size_t (on e.g. x86).
Reject them summarily.