Skip to content

Introduce Profiles page to SUI#20199

Open
carlos-zamora wants to merge 7 commits into
mainfrom
dev/cazamor/sui-rejuv/profiles
Open

Introduce Profiles page to SUI#20199
carlos-zamora wants to merge 7 commits into
mainfrom
dev/cazamor/sui-rejuv/profiles

Conversation

@carlos-zamora
Copy link
Copy Markdown
Member

@carlos-zamora carlos-zamora commented May 8, 2026

Summary of the Pull Request

Updates the settings UI to introduce a new Profiles page. This page includes:

  • a "Profile Defaults" navigator
  • a "Color Schemes" navigator (removed top-level item in favor of this)
  • an "add profile" button
  • a navigator for each profile
    • tooltips were added for the "hidden"/"orphaned" info badge

Validation Steps Performed

Scenarios:

  • settings search
  • breadcrumbs
  • navigate to individual profiles
  • update settings for a profile
  • accessibility testing

PR Checklist

Related to #17000

Comment thread src/cascadia/TerminalSettingsEditor/MainPage.cpp Fixed
Comment thread src/cascadia/TerminalSettingsEditor/MainPage.cpp Fixed
Comment thread src/cascadia/TerminalSettingsEditor/MainPage.cpp Fixed
Comment thread src/cascadia/TerminalSettingsEditor/MainPage.cpp Fixed
Comment thread src/cascadia/TerminalSettingsEditor/MainPage.cpp Fixed
Comment thread src/cascadia/TerminalSettingsEditor/MainPage.h Fixed
@carlos-zamora

This comment was marked as outdated.

@github-actions

This comment was marked as resolved.

@carlos-zamora carlos-zamora mentioned this pull request May 8, 2026
20 tasks
@carlos-zamora
Copy link
Copy Markdown
Member Author

Demo

image

Things to note:

  • "Color schemes" has been removed from the navigation view
  • regular text styling is used for navigator's header text (this is consistent with Windows Community Toolkit's SettingsCard/Expander)
  • Orphaned/Hidden InfoBadges reveal a tooltip when displayed. It's its own resource because that text is more fitting than reusing an existing one
  • The entire page can be navigated using the arrow keys (nice QOL feature)
  • screen readers read out the description and info badges appropriately
  • settings search was validated to still work. Color schemes now show "Color schemes" as a subtitle for clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants