Only set startingTitle once, clear up title fallback handling#20214
Merged
Conversation
This commit ensures that we only set the starting title once when we open a new terminal pane. It also consolidates all title selection into Terminal::GetConsoleTitle, which is now used in the TitleChanged event. TitleChanged no longer stores a separate copy of the starting title if an application attempts to _clear_ the title; that seems like a poorer implementation of what we already had. This supersedes work in #20204. Closes #19340 Closes #20204 Co-authored-by: imsh <im.shaedar@gmail.com>
Member
Author
lhecker
approved these changes
May 11, 2026
Contributor
|
@DHowett Thanks for fixing it! Just one note, I've discovered that the |
Member
Author
|
@imsh you're right; however, that's part of a bigger problem where commandline-originated NewTerminalArgs get lost or ignored over time |
Member
Author
|
(I'd like to solve it all at once) |
DHowett
added a commit
that referenced
this pull request
May 12, 2026
This commit ensures that we only set the starting title once when we open a new terminal pane. It also consolidates all title selection into Terminal::GetConsoleTitle, which is now used in the TitleChanged event. TitleChanged no longer stores a separate copy of the starting title if an application attempts to _clear_ the title; that seems like a poorer implementation of what we already had. This supersedes work in #20204. Closes #19340 Closes #20204 Co-authored-by: imsh <im.shaedar@gmail.com> (cherry picked from commit b991eb0) Service-Card-Id: PVTI_lADOAF3p4s4BBcTlzgfZJdA Service-Version: 1.24
DHowett
added a commit
that referenced
this pull request
May 12, 2026
This commit ensures that we only set the starting title once when we open a new terminal pane. It also consolidates all title selection into Terminal::GetConsoleTitle, which is now used in the TitleChanged event. TitleChanged no longer stores a separate copy of the starting title if an application attempts to _clear_ the title; that seems like a poorer implementation of what we already had. This supersedes work in #20204. Closes #19340 Closes #20204 Co-authored-by: imsh <im.shaedar@gmail.com> (cherry picked from commit b991eb0) Service-Card-Id: PVTI_lADOAF3p4s4BQX0-zgmWldU Service-Version: 1.25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit ensures that we only set the starting title once when we open a new terminal pane.
It also consolidates all title selection into Terminal::GetConsoleTitle, which is now used in the TitleChanged event.
TitleChanged no longer stores a separate copy of the starting title if an application attempts to clear the title; that seems like a poorer implementation of what we already had.
This supersedes work in #20204.
Closes #19340
Closes #20204