Fix #8264: detect pwsh in custom Scoop locations#20247
Open
Adesh4477 wants to merge 1 commit into
Open
Conversation
Author
|
@microsoft-github-policy-service agree |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
microsoft-github-policy-service
Bot
added
Issue-Task
Terminal only checked %USERPROFILE%\scoop\shims for pwsh.exe, so users who installed Scoop to a custom or global location is getting missed. its looking in default location only. Changes: - Add _getEnvironmentVariable() helper to safely read env vars. - Add PowerShellFlags::ScoopGlobal so global-scope installs get a distinct profile name (and GUID) from user-scope installs. - User-scope: custom %SCOOP% if set, else fall back to the default location no duplicates possible. - Global-scope: if %SCOOP_GLOBAL% is set, also add a separate "PowerShell (scoop global)" profile. At most two Scoop profiles are produced (one user (custom/default), one global). Verified manually by pointing both env vars at test directories containing pwsh.exe and confirming the profiles appear in the dropdown and getting launch successfully.
Adesh4477
force-pushed
the
fix/issue-8264-pwsh-scoop-detection
branch
from
466185b to
d932420
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8264
Terminal only checked %USERPROFILE%\scoop\shims for pwsh.exe, so
users who installed Scoop to a custom or global location is getting missed.
its looking in default location only.
Changes:
At most two Scoop profiles are produced (one user (custom/default), one global).
Verified manually by pointing both env vars at test directories
containing pwsh.exe and confirming the profiles appear in the
dropdown and getting launch successfully.
Summary of the Pull Request
References and Relevant Issues
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
PR Checklist